Skip to content

AGENT-1372: Rename NoRegistryClusterOperations to NoRegistryClusterInstall #2586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 1 commit into from
Nov 19, 2025
Merged

AGENT-1372: Rename NoRegistryClusterOperations to NoRegistryClusterInstall #2586

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion features.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
| NewOLMCatalogdAPIV1Metas| | | | <span style="background-color: #519450">Enabled</span> | | <span style="background-color: #519450">Enabled</span> |
| NewOLMOwnSingleNamespace| | | | <span style="background-color: #519450">Enabled</span> | | <span style="background-color: #519450">Enabled</span> |
| NewOLMPreflightPermissionChecks| | | | <span style="background-color: #519450">Enabled</span> | | <span style="background-color: #519450">Enabled</span> |
| NoRegistryClusterOperations| | | | <span style="background-color: #519450">Enabled</span> | | <span style="background-color: #519450">Enabled</span> |
| NoRegistryClusterInstall| | | | <span style="background-color: #519450">Enabled</span> | | <span style="background-color: #519450">Enabled</span> |
| NewOLM| | <span style="background-color: #519450">Enabled</span> | | <span style="background-color: #519450">Enabled</span> | | <span style="background-color: #519450">Enabled</span> |
| NewOLMWebhookProviderOpenshiftServiceCA| | <span style="background-color: #519450">Enabled</span> | | <span style="background-color: #519450">Enabled</span> | | <span style="background-color: #519450">Enabled</span> |
| AWSClusterHostedDNS| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
Expand Down
2 changes: 1 addition & 1 deletion features/features.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -799,7 +799,7 @@ var (
enableIn(configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade, configv1.Default).
mustRegister()

FeatureGateNoRegistryClusterOperations = newFeatureGate("NoRegistryClusterOperations").
FeatureGateNoRegistryClusterInstall = newFeatureGate("NoRegistryClusterInstall").
Copy link
Copy Markdown
Contributor

@everettraven everettraven Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just as a sanity check - there is nothing that relies on this today that may break due to this rename?

Copy link
Copy Markdown
Contributor

@everettraven everettraven Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've answered my own question by looking at the existing test failures - those look unrelated so this should be OK as it has never gone beyond TPNU.

reportProblemsToJiraComponent("Installer / Agent based installation").
contactPerson("andfasano").
productScope(ocpSpecific).
Expand Down
2 changes: 1 addition & 1 deletion payload-manifests/featuregates/featureGate-Hypershift-Default.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@
"name": "NewOLMWebhookProviderOpenshiftServiceCA"
},
{
"name": "NoRegistryClusterOperations"
"name": "NoRegistryClusterInstall"
},
{
"name": "NutanixMultiSubnets"
Expand Down
2 changes: 1 addition & 1 deletion payload-manifests/featuregates/featureGate-Hypershift-DevPreviewNoUpgrade.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
"name": "NewOLMWebhookProviderOpenshiftServiceCA"
},
{
"name": "NoRegistryClusterOperations"
"name": "NoRegistryClusterInstall"
},
{
"name": "ShortCertRotation"
Expand Down
2 changes: 1 addition & 1 deletion payload-manifests/featuregates/featureGate-Hypershift-TechPreviewNoUpgrade.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
"name": "NewOLMWebhookProviderOpenshiftServiceCA"
},
{
"name": "NoRegistryClusterOperations"
"name": "NoRegistryClusterInstall"
},
{
"name": "ShortCertRotation"
Expand Down
2 changes: 1 addition & 1 deletion payload-manifests/featuregates/featureGate-SelfManagedHA-Default.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@
"name": "NewOLMPreflightPermissionChecks"
},
{
"name": "NoRegistryClusterOperations"
"name": "NoRegistryClusterInstall"
},
{
"name": "NutanixMultiSubnets"
Expand Down
2 changes: 1 addition & 1 deletion payload-manifests/featuregates/featureGate-SelfManagedHA-DevPreviewNoUpgrade.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@
"name": "NewOLMWebhookProviderOpenshiftServiceCA"
},
{
"name": "NoRegistryClusterOperations"
"name": "NoRegistryClusterInstall"
},
{
"name": "NutanixMultiSubnets"
Expand Down
2 changes: 1 addition & 1 deletion payload-manifests/featuregates/featureGate-SelfManagedHA-TechPreviewNoUpgrade.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@
"name": "NewOLMWebhookProviderOpenshiftServiceCA"
},
{
"name": "NoRegistryClusterOperations"
"name": "NoRegistryClusterInstall"
},
{
"name": "NutanixMultiSubnets"
Expand Down