AGENT-1372: Rename NoRegistryClusterOperations to NoRegistryClusterInstall

[rwsu]

Renamed the feature gate from NoRegistryClusterOperations to NoRegistryClusterInstall to better reflect that this feature gate controls installation rather than general cluster operations.

Installation includes initial cluster installation and adding nodes during day 2.

[openshift-ci-robot]

Pipeline controller notification
This repository is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. Review these jobs and use /test <job> to manually trigger optional jobs most likely to be impacted by the proposed changes.

[openshift-ci-robot]

@rwsu: This pull request references AGENT-1372 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

Details

In response to this:

Renamed the feature gate from NoRegistryClusterOperations to NoRegistryClusterInstall to better reflect that this feature gate controls installation rather than general cluster operations.

Installation includes initial cluster installation and adding nodes during day 2.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Hello @rwsu! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[andfasano]

/lgtm

[openshift-ci-robot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change

[coderabbitai]

Walkthrough

A feature gate has been systematically renamed from NoRegistryClusterOperations to NoRegistryClusterInstall across the codebase. The renaming is applied consistently in feature gate definitions, documentation, and deployment configuration files without any changes to underlying logic or structure.

Changes

Cohort / File(s)	Summary
Feature Gate Definition features.md, features/features.go	Renamed public feature gate entry and constant from NoRegistryClusterOperations to NoRegistryClusterInstall; updated feature name string passed to gate initialization
Feature Gate Configuration payload-manifests/featuregates/featureGate-Hypershift-*.yaml (3 files)	Updated disabled feature gate name from NoRegistryClusterOperations to NoRegistryClusterInstall across Hypershift profile configurations (Default, DevPreviewNoUpgrade, TechPreviewNoUpgrade)
Feature Gate Configuration payload-manifests/featuregates/featureGate-SelfManagedHA-*.yaml (3 files)	Updated feature gate name from NoRegistryClusterOperations to NoRegistryClusterInstall across SelfManagedHA profiles (disabled in Default, enabled in DevPreviewNoUpgrade and TechPreviewNoUpgrade)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

• Verify that the rename is consistent across all files and feature gate profiles
• Confirm that no references to the old feature gate name remain in the codebase
• Ensure the renaming aligns with feature gate naming conventions and any related documentation updates

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between 348370f and 5e3346b.

📒 Files selected for processing (8)

• features.md (1 hunks)
• features/features.go (1 hunks)
• payload-manifests/featuregates/featureGate-Hypershift-Default.yaml (1 hunks)
• payload-manifests/featuregates/featureGate-Hypershift-DevPreviewNoUpgrade.yaml (1 hunks)
• payload-manifests/featuregates/featureGate-Hypershift-TechPreviewNoUpgrade.yaml (1 hunks)
• payload-manifests/featuregates/featureGate-SelfManagedHA-Default.yaml (1 hunks)
• payload-manifests/featuregates/featureGate-SelfManagedHA-DevPreviewNoUpgrade.yaml (1 hunks)
• payload-manifests/featuregates/featureGate-SelfManagedHA-TechPreviewNoUpgrade.yaml (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

**

⚙️ CodeRabbit configuration file

-Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity.

Files:

• payload-manifests/featuregates/featureGate-Hypershift-TechPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-Hypershift-Default.yaml
• features.md
• payload-manifests/featuregates/featureGate-SelfManagedHA-DevPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-Hypershift-DevPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-SelfManagedHA-Default.yaml
• features/features.go
• payload-manifests/featuregates/featureGate-SelfManagedHA-TechPreviewNoUpgrade.yaml

🔇 Additional comments (8)

payload-manifests/featuregates/featureGate-Hypershift-TechPreviewNoUpgrade.yaml (1)

57-57: LGTM! Feature gate rename applied correctly.

The rename from NoRegistryClusterOperations to NoRegistryClusterInstall is applied consistently in the disabled feature gates list.

payload-manifests/featuregates/featureGate-SelfManagedHA-TechPreviewNoUpgrade.yaml (1)

269-269: LGTM! Feature gate rename applied correctly.

The rename from NoRegistryClusterOperations to NoRegistryClusterInstall is applied consistently in the enabled feature gates list.

payload-manifests/featuregates/featureGate-Hypershift-DevPreviewNoUpgrade.yaml (1)

45-45: LGTM! Feature gate rename applied correctly.

The rename from NoRegistryClusterOperations to NoRegistryClusterInstall is applied consistently in the disabled feature gates list.

payload-manifests/featuregates/featureGate-SelfManagedHA-Default.yaml (1)

184-184: LGTM! Feature gate rename applied correctly.

The rename from NoRegistryClusterOperations to NoRegistryClusterInstall is applied consistently in the disabled feature gates list.

payload-manifests/featuregates/featureGate-Hypershift-Default.yaml (1)

190-190: LGTM! Feature gate rename applied correctly.

The rename from NoRegistryClusterOperations to NoRegistryClusterInstall is applied consistently in the disabled feature gates list.

payload-manifests/featuregates/featureGate-SelfManagedHA-DevPreviewNoUpgrade.yaml (1)

269-269: LGTM! Feature gate rename applied correctly.

The rename from NoRegistryClusterOperations to NoRegistryClusterInstall is applied consistently in the enabled feature gates list.

features/features.go (1)

802-808: LGTM! Feature gate rename applied correctly in code.

The feature gate constant and string literal have been renamed from FeatureGateNoRegistryClusterOperations/"NoRegistryClusterOperations" to FeatureGateNoRegistryClusterInstall/"NoRegistryClusterInstall". The feature gate configuration (enablement profiles, contact person, enhancement PR) remains unchanged, ensuring no behavioral changes.

features.md (1)

15-15: LGTM! Documentation updated to reflect feature gate rename.

The feature gate name in the documentation table has been updated from NoRegistryClusterOperations to NoRegistryClusterInstall, preserving the enabled states across all cluster profiles.

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.5.0)

Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented
The command is terminated due to an error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[everettraven]

Just as a sanity check - there is nothing that relies on this today that may break due to this rename?

[everettraven]

I've answered my own question by looking at the existing test failures - those look unrelated so this should be OK as it has never gone beyond TPNU.

[everettraven]

/lgtm

/retest-required

[everettraven]

@rwsu over to you to get the verified label added.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano, everettraven

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [everettraven]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rwsu]

/verified by @rwsu

[openshift-ci-robot]

@rwsu: This PR has been marked as verified by @rwsu.

Details

In response to this:

/verified by @rwsu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD b6fddd3 and 2 for PR HEAD 5e3346b in total

[openshift-ci]

@rwsu: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.