Skip to content

OCPBUGS-55665: Remove featuregate ChunkSizeMib #2438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 12, 2025
Merged

OCPBUGS-55665: Remove featuregate ChunkSizeMib #2438

merged 1 commit into from
Aug 12, 2025

Conversation

@deepsm007
Copy link
Contributor

@deepsm007 deepsm007 commented Aug 5, 2025

@openshift-ci openshift-ci bot requested a review from flavianmissi August 5, 2025 15:29
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 5, 2025

Hello @deepsm007! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Aug 5, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 5, 2025

@deepsm007: This pull request references Jira Issue OCPBUGS-55665, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/cc @flavianmissi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 5, 2025
@deepsm007 deepsm007 mentioned this pull request Aug 5, 2025
Open
@deepsm007 deepsm007 force-pushed the remove-chunksize-var branch from 419ebe1 to 1390410 Compare August 5, 2025 17:11
@deepsm007
Copy link
Contributor Author

deepsm007 commented Aug 5, 2025

/assign @JoelSpeed

@deepsm007
Copy link
Contributor Author

deepsm007 commented Aug 6, 2025

/retest

flavianmissi
flavianmissi reviewed Aug 6, 2025
View reviewed changes
@deepsm007 deepsm007 force-pushed the remove-chunksize-var branch 2 times, most recently from 3dc3bdf to 8767594 Compare August 6, 2025 11:31
@deepsm007 deepsm007 force-pushed the remove-chunksize-var branch 2 times, most recently from ecc12cf to d3db6f5 Compare August 6, 2025 11:47
@JoelSpeed
Copy link
Contributor

JoelSpeed commented Aug 6, 2025

You'll need to remove the featuregates key from the test file for this to work

@deepsm007 deepsm007 force-pushed the remove-chunksize-var branch from d3db6f5 to e772c0a Compare August 6, 2025 15:28
@JoelSpeed
Copy link
Contributor

JoelSpeed commented Aug 6, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 6, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepsm007, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 6, 2025

/retest-required

Remaining retests: 0 against base HEAD 7605f9b and 2 for PR HEAD e772c0a in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 7, 2025

/retest-required

Remaining retests: 0 against base HEAD 3315d66 and 1 for PR HEAD e772c0a in total

@flavianmissi
Copy link
Member

flavianmissi commented Aug 7, 2025

/retest

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 8, 2025

/retest-required

Remaining retests: 0 against base HEAD a42cd21 and 2 for PR HEAD e772c0a in total

@JoelSpeed
Copy link
Contributor

JoelSpeed commented Aug 8, 2025

/retest-required

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 8, 2025

/retest-required

Remaining retests: 0 against base HEAD 356d265 and 1 for PR HEAD e772c0a in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 8, 2025

/retest-required

Remaining retests: 0 against base HEAD c974eea and 0 for PR HEAD e772c0a in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 8, 2025

/hold

Revision e772c0a was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 8, 2025
@deepsm007
Copy link
Contributor Author

deepsm007 commented Aug 12, 2025

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 12, 2025
@JoelSpeed
Copy link
Contributor

JoelSpeed commented Aug 12, 2025

/test all

Main has moved since these were tested so the results are all stale

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 12, 2025

/retest-required

Remaining retests: 0 against base HEAD 8187a76 and 2 for PR HEAD e772c0a in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 12, 2025

@deepsm007: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp e772c0a link false /test e2e-gcp
ci/prow/e2e-azure e772c0a link false /test e2e-azure
ci/prow/okd-scos-e2e-aws-ovn e772c0a link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 88b2b21 into openshift:master Aug 12, 2025
24 of 27 checks passed
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 12, 2025

@deepsm007: Jira Issue OCPBUGS-55665: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-55665 has been moved to the MODIFIED state.

In response to this:

/cc @flavianmissi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link

openshift-bot commented Aug 13, 2025

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api
This PR has been included in build ose-cluster-config-api-container-v4.20.0-202508130315.p0.g88b2b21.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@flavianmissi flavianmissi flavianmissi left review comments

@JoelSpeed JoelSpeed JoelSpeed left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@JoelSpeed JoelSpeed

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@deepsm007 @openshift-ci-robot @JoelSpeed @flavianmissi @openshift-bot