-
Notifications
You must be signed in to change notification settings - Fork 135
NO-JIRA: Remove ChunkSizeMib featuregate #1240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
b349985 to
641b9d7
Compare
74bd59a to
9ae0bc1
Compare
|
/retest |
1 similar comment
|
/retest |
|
/retest-required |
|
/retest |
340c2b6 to
edba1e4
Compare
|
I have rebased the PR, the previous failures were not related to the code changes. Hypershift test failed due to infrastructure issue, retesting again. |
|
/retest |
edba1e4 to
41c150c
Compare
|
/retest |
|
/approve |
|
/retest-required |
|
/test e2e-vsphere-operator e2e-aws-operator |
|
the e2e-*-operator tests are flaking so much that at this point they're nearly perma-failing, and this isn't the case for this PR only, it's happening across the board. /override ci/prow/e2e-aws-operator |
|
@flavianmissi: Overrode contexts on behalf of flavianmissi: ci/prow/e2e-aws-operator, ci/prow/e2e-vsphere-operator In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
41c150c to
503ccc8
Compare
|
/override ci/prow/e2e-aws-operator |
|
@flavianmissi: Overrode contexts on behalf of flavianmissi: ci/prow/e2e-aws-operator, ci/prow/e2e-vsphere-operator In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm |
|
/retitle NO-JIRA: Remove ChunkSizeMib featuregate |
|
@deepsm007: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
this feature gate has been enabled for a few releases now, so removing it does not affect end users. /label px-approved |
|
Hi @xiuwang! Could you please help us with verifying this? It's really just an openshift/api bump, the actual feature gate removal was done in openshift/api#2438. |
|
/retest-required |
|
/verified by @xiuwang |
|
@xiuwang: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@xiuwang can you override the one failing test? #1240 (comment) @flavianmissi is not around for several weeks now |
|
/retest-required |
|
/override ci/prow/e2e-gcp-operator |
|
@xiuwang: xiuwang unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers openshift-sustaining-engineers. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@deepsm007 I have no permission to do override |
|
@deepsm007 I am concerned with the failing tests. Can you please see what is going on with those ? We seem to have unit tests failing as well. |
I see a lot of connection refused for all 3 failures Also #1240 (comment), i will spend some time investigating further. And also #1240 (comment) |
|
/retest-required |
|
unfortunately the e2e-.*-operator tests seem to be perma-failing. /override ci/prow/e2e-vsphere-operator |
|
@flavianmissi: Overrode contexts on behalf of flavianmissi: ci/prow/e2e-vsphere-operator In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@deepsm007: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest-required |
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cc @flavianmissi
wait for openshift/api#2438