OPRUN-3588: Add OperatorLifecycleManagerV1 cluster version capability #2066
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Hello @perdasilva! Some important instructions when contributing to openshift/api: |
openshift-ci
bot
added
the
size/M
perdasilva
force-pushed
the
perdasilva/capability/olmv1
branch
2 times, most recently
from
973c383 to
e234102
Compare
openshift-ci
bot
added
size/L
perdasilva
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@perdasilva: This pull request references OPRUN-3588 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
@perdasilva: This pull request references OPRUN-3588 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@perdasilva: This pull request references OPRUN-3588 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@perdasilva: This pull request references OPRUN-3588 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@perdasilva: This pull request references OPRUN-3588 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@perdasilva: This pull request references OPRUN-3588 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
perdasilva
force-pushed
the
perdasilva/capability/olmv1
branch
2 times, most recently
from
a588840 to
9393877
Compare
perdasilva
changed the title
perdasilva
changed the title
|
@perdasilva: This pull request references OPRUN-3588 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
perdasilva
force-pushed
the
perdasilva/capability/olmv1
branch
from
9393877 to
67ff31f
Compare
|
/lgtm |
|
@perdasilva: This pull request references OPRUN-3588 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Does it matter that OLMv1 is showing up in the Default capability set before we actually have it in the default payload?
config/v1/types_cluster_version.go
Outdated
|
|
||
| // ClusterVersionCapabilityOLMv1 manages the Operator Lifecycle Manager (v1) | ||
| // which itself manages the lifecycle of operators | ||
| ClusterVersionCapabilityOLMv1 ClusterVersionCapability = "OLMv1" |
There was a problem hiding this comment.
No abbreviations. It'll look silly, but it must be spelled out.
There was a problem hiding this comment.
I totally know where that's coming from. But we've had a bunch of upstream consternation on the team with the project name, now that we're trying to expand beyond operators, so we were trying to do a "Kentucky Fried Chicken" -> "KFC" sort of thing to diminish the "Operator" terminology without completely leaving behind the OLM branding.
If we go with OperatorLifecycleManagerV1 now, but in the future determine that the "Operator" branding is hurting our ability to position the project for growing beyond operators, what would it look like to rename?
Signed-off-by: Per Goncalves da Silva <[email protected]>
perdasilva
force-pushed
the
perdasilva/capability/olmv1
branch
from
67ff31f to
a5347b6
Compare
perdasilva
changed the title
|
@perdasilva: This pull request references OPRUN-3588 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, joelanford, perdasilva The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@perdasilva: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[ART PR BUILD NOTIFIER] Distgit: ose-cluster-config-api |
Catching up with [1]. Generated with: $ go get github.com/openshift/api@master $ go mod tidy $ go mod vendor $ git add -A go.* vendor $ go version go version go1.22.2 linux/amd64 [1] openshift/api/pull/2066 Signed-off-by: Lalatendu Mohanty <[email protected]>
Catching up with [1]. Generated with: $ go get github.com/openshift/api@a2817b89f7e0989016967055a142d5e88bed18de $ go get github.com/openshift/client-go@923091dd2b1a3d6fe75a06cc4f45972a3ddf84c2 $ go get github.com/openshift/library-go@0064ad7bd060b9fd52f7840972c1d3e72186d0f0 $ go mod tidy $ go mod vendor $ git add -A go.* vendor $ go version go version go1.22.5 linux/amd64 [1] openshift/api/pull/2066 Signed-off-by: Lalatendu Mohanty <[email protected]>
Catching up with [1]. Generated with: $ go get github.com/openshift/api@a2817b89f7e0989016967055a142d5e88bed18de $ go get github.com/openshift/client-go@923091dd2b1a3d6fe75a06cc4f45972a3ddf84c2 $ go get github.com/openshift/library-go@0064ad7bd060b9fd52f7840972c1d3e72186d0f0 $ go mod tidy $ go mod vendor $ git add -A go.* vendor $ go version go version go1.22.5 linux/amd64 [1] openshift/api/pull/2066 Signed-off-by: Lalatendu Mohanty <[email protected]>
5 participants
Preconditions:
Changes:
Next PR: openshift/cluster-olm-operator#74