OPRUN-3402: ⚠️ Bump OLM API to v1

[perdasilva]

• Promotes operator/v1alpha1 OLM to operator/v1 OLM

Next PR: #2066

[openshift-ci]

Hello @perdasilva! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[perdasilva]

verify-crd-schema is failing because observedGeneration is not in OperatorCondition. We've reached out on the #forum-api-review to see if this is something we should override. slack thread

[JoelSpeed]

@perdasilva You need to ensure your project is checked out under an appropriate $GOPATH or, not run the protobuf generator

Looking at the PR, I think protobuf generation is not required, so perhaps revert all the proto related changes and run the updates with PROTO_OPTIONAL=1

[perdasilva]

Thanks @JoelSpeed ^^ I just saw the message on the api forum XD - should be fixed up now (I hope)

[perdasilva]

/retest

[perdasilva]

/retest

[perdasilva]

/retest

[openshift-ci-robot]

@perdasilva: This pull request references OPRUN-3402 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.18.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@perdasilva: This pull request references OPRUN-3402 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.18.0" version, but no target version was set.

Details

In response to this:

• Promotes operator/v1alpha1 OLM to operator/v1 OLM
• Removes operator/v1alpha1 OLM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@perdasilva: This pull request references OPRUN-3402 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.18.0" version, but no target version was set.

Details

In response to this:

• Promotes operator/v1alpha1 OLM to operator/v1 OLM
• Removes operator/v1alpha1 OLM

Next PR: #2066

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[perdasilva]

/jira refresh

[openshift-ci-robot]

@perdasilva: This pull request references OPRUN-3402 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[perdasilva]

@JoelSpeed This should be ready for review ^^

The failure in verify-crd-schema is:

 	could not run schemacheck generator for group/version operator.openshift.io/v1: 
		error in operator/v1/zz_generated.crd-manifests/0000_10_operator-lifecycle-manager_01_olms.crd.yaml: ConditionsMustHaveProperSSATags: crd/olms.operator.openshift.io version/v1 field/^.status.condition must define valid condition properties: observedGeneration attribute is missing
		error in operator/v1/zz_generated.featuregated-crd-manifests/olms.operator.openshift.io/AAA_ungated.yaml: ConditionsMustHaveProperSSATags: crd/olms.operator.openshift.io version/v1 field/^.status.condition must define valid condition properties: observedGeneration attribute is missing
+ echo This verifier checks all files that have changed. In some cases you may have changed or renamed a file that already contained api violations, but you are not introducing a new violation. In such cases it is appropriate to /override the failing CI job.
This verifier checks all files that have changed. In some cases you may have changed or renamed a file that already contained api violations, but you are not introducing a new violation. In such cases it is appropriate to /override the failing CI job. 

as discussed here, it should be ok to override.

(cc @joelanford)

[JoelSpeed]

When bumping an API from v1alpha1 to v1, we must keep the old types around for some time. We need to be able to generate clients for both v1alpha1 and v1 simultaneously to allow users to build tooling versions that might span both GA and pre-GA

Please restore the v1alpha1 versions, and then I'll review the v1 API again to see if there's anything we might need to update prior to GA

[openshift-ci-robot]

@perdasilva: This pull request references OPRUN-3402 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

Details

In response to this:

• Promotes operator/v1alpha1 OLM to operator/v1 OLM

Next PR: #2066

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[perdasilva]

When bumping an API from v1alpha1 to v1, we must keep the old types around for some time. We need to be able to generate clients for both v1alpha1 and v1 simultaneously to allow users to build tooling versions that might span both GA and pre-GA

Please restore the v1alpha1 versions, and then I'll review the v1 API again to see if there's anything we might need to update prior to GA

@JoelSpeed Thanks for clarifying that. We really weren't sure if it would be ok given the support requirements, but didn't factor in other technical considerations. I've gone ahead and restored v1alpha1.

[perdasilva]

/jira refresh

[openshift-ci-robot]

@perdasilva: This pull request references OPRUN-3402 which is a valid jira issue.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[JoelSpeed]

Has this been tested and we are happy that it works?

[perdasilva]

yup yup - we have a test for it https://github.com/openshift/api/pull/2061/files#diff-34775f0b3bbcc2a64f685c6fc398e13b3fae20851398b2b5a455726630673a01R21

I've also gone ahead and manually tested on a clusterbot. Looks good ^^

[JoelSpeed]

Is there a related feature gate that also needs to be promoted?

What is the path to GA for this feature?

Do we have enough time to complete the path to GA prior to branch cutting?

[JoelSpeed]

/lgtm

/override ci/prow/verify-crd-schema

Existing failures about observed generation cannot be resolved now

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-crd-schema

Details

In response to this:

/lgtm

/override ci/prow/verify-crd-schema

Existing failures about observed generation cannot be resolved now

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

@perdasilva: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api
This PR has been included in build ose-cluster-config-api-container-v4.18.0-202411071810.p0.gd37bb9f.assembly.stream.el9.
All builds following this will include this PR.