Skip to content

config/v1/types_cluster_version: Add CBO #1125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Mar 3, 2022
Merged

config/v1/types_cluster_version: Add CBO #1125

openshift-merge-robot merged 1 commit into from
Mar 3, 2022

Conversation

@honza
Copy link
Member

@honza honza commented Feb 28, 2022

Add cluster-baremetal-operator as a capability

@openshift-ci openshift-ci bot requested review from mfojtik and soltysh February 28, 2022 15:20
@honza
Copy link
Member Author

honza commented Mar 2, 2022

@wking Would you mind having a look since you added the initial capability code?

wking
wking reviewed Mar 2, 2022
View reviewed changes
wking
wking reviewed Mar 2, 2022
View reviewed changes
wking
wking reviewed Mar 3, 2022
View reviewed changes
wking
wking reviewed Mar 3, 2022
View reviewed changes
@honza
config/v1/types_cluster_version: Add baremetal
5c12820 
Add cluster baremetal operator as a capability
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 3, 2022

@honza: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

wking
wking approved these changes Mar 3, 2022
View reviewed changes
Copy link
Member

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 3, 2022
@deads2k
Copy link
Contributor

deads2k commented Mar 3, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 3, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, honza, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2022
@deads2k deads2k added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). labels Mar 3, 2022
@openshift-merge-robot openshift-merge-robot merged commit 5170e8d into openshift:master Mar 3, 2022
@honza honza deleted the cbo-capability branch March 3, 2022 17:17
@honza honza mentioned this pull request Mar 3, 2022
Merged
@wking wking mentioned this pull request Mar 11, 2022
Merged
@wking wking mentioned this pull request Mar 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mfojtik mfojtik Awaiting requested review from mfojtik

@soltysh soltysh Awaiting requested review from soltysh

1 more reviewer

@wking wking wking approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@wking wking

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@honza @deads2k @wking @openshift-merge-robot