Consume post install static spec capabilities #744

jottofar · 2022-02-21T16:14:42Z

Implements initial, postinstall, support of static capabilities
per Jira OTA-567.

lib/capability/capability.go

wking · 2022-02-28T22:37:47Z

lib/capability/capability.go

+				continue
+			}
+			known[capability] = struct{}{}
+			config.Status.Capabilities.KnownCapabilities = append(config.Status.Capabilities.KnownCapabilities, capability)


Do we have reliable locking on this? With the status sync'er running in parallel, I'd expect at least something like building a slice in a local variable, and after completing the local array, slotting it in with:

config.Status.Capabilities.KnownCapabilities = knownCapabilities

This is old code and will be removed but the question of the need for a lock is valid.

The capabilities reside in get set SyncWork and are set in Update so are protected by the lock there. Just yesterday I added setting CapabilitiesStatus in SyncWorkerStatus also in Update here so it's available to syncStatus here.

lib/capability/capability.go

jottofar · 2022-03-01T16:06:12Z

/retitle Consume post install static spec capabilities

jottofar · 2022-03-03T17:37:28Z

retitle WIP: Consume post install static spec capabilities

Get cluster version object earlier in startup needs to land first and unit test fixes in progress.

jottofar · 2022-03-03T20:48:26Z

/retitle WIP: Consume post install static spec capabilities

jottofar · 2022-03-04T14:44:48Z

/test e2e-agnostic

jottofar · 2022-03-11T21:11:45Z

/retitle Consume post install static spec capabilities

lib/capability/capability.go

lib/capability/capability_test.go

wking · 2022-03-11T21:51:30Z

pkg/cvo/cvo_scenarios_test.go

 	}
 	actions = client.Actions()
-	if len(actions) != 1 {
+	if len(actions) != 2 {


what is the second action here?

Update to ClusterVersion

Can we grow an expectUpdateStatus or some such to enforce that?

Implements initial, postinstall, support of static capabilities per Jira OTA-567.

wking

/lgtm

sandbox and PBD issues are orthogonal.

/override ci/prow/e2e-agnostic-upgrade

openshift-ci · 2022-03-14T18:33:37Z

@wking: Overrode contexts on behalf of wking: ci/prow/e2e-agnostic-upgrade

Details

In response to this:

/lgtm

sandbox and PBD issues are orthogonal.

/override ci/prow/e2e-agnostic-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-03-14T18:33:46Z

@jottofar: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci · 2022-03-14T18:33:47Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jottofar, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [jottofar,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 21, 2022

openshift-ci bot requested review from vrutkovs and wking February 21, 2022 16:17

openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 21, 2022

jottofar force-pushed the ota-567 branch 2 times, most recently from d9825a8 to abafa60 Compare February 28, 2022 21:42

openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 28, 2022

wking reviewed Feb 28, 2022

View reviewed changes

lib/capability/capability.go Outdated Show resolved Hide resolved

wking reviewed Feb 28, 2022

View reviewed changes

lib/capability/capability.go Show resolved Hide resolved

wking reviewed Feb 28, 2022

View reviewed changes

lib/capability/capability.go Outdated Show resolved Hide resolved

wking reviewed Feb 28, 2022

View reviewed changes

lib/capability/capability.go Outdated Show resolved Hide resolved

jottofar force-pushed the ota-567 branch from abafa60 to 32c6ba1 Compare March 1, 2022 16:04

openshift-ci bot changed the title ~~WIP: Consume post install static spec capabilities~~ Consume post install static spec capabilities Mar 1, 2022

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 1, 2022

jottofar force-pushed the ota-567 branch 4 times, most recently from e850c3d to 999a747 Compare March 3, 2022 17:23

jottofar force-pushed the ota-567 branch 3 times, most recently from 711c695 to 662bb9a Compare March 3, 2022 19:10

openshift-ci bot changed the title ~~Consume post install static spec capabilities~~ WIP: Consume post install static spec capabilities Mar 3, 2022

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 3, 2022

jottofar force-pushed the ota-567 branch from 662bb9a to 96fe143 Compare March 11, 2022 15:23

jottofar force-pushed the ota-567 branch from 96fe143 to 3027b44 Compare March 11, 2022 20:08

openshift-ci bot changed the title ~~WIP: Consume post install static spec capabilities~~ Consume post install static spec capabilities Mar 11, 2022

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 11, 2022

jottofar force-pushed the ota-567 branch from 3027b44 to fa5c473 Compare March 11, 2022 21:12

wking reviewed Mar 11, 2022

View reviewed changes

lib/capability/capability.go Outdated Show resolved Hide resolved

wking reviewed Mar 11, 2022

View reviewed changes

lib/capability/capability.go Outdated Show resolved Hide resolved

wking reviewed Mar 11, 2022

View reviewed changes

lib/capability/capability_test.go Outdated Show resolved Hide resolved

wking reviewed Mar 11, 2022

View reviewed changes

lib/capability/capability_test.go Outdated Show resolved Hide resolved

wking reviewed Mar 11, 2022

View reviewed changes

Consume post install static spec capabilities

80d8a57

Implements initial, postinstall, support of static capabilities per Jira OTA-567.

jottofar force-pushed the ota-567 branch from fa5c473 to 80d8a57 Compare March 14, 2022 14:11

wking approved these changes Mar 14, 2022

View reviewed changes

openshift-ci bot assigned wking Mar 14, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 14, 2022

openshift-merge-robot merged commit 1699e32 into openshift:master Mar 14, 2022

Consume post install static spec capabilities #744

Consume post install static spec capabilities #744

Uh oh!

Conversation

jottofar commented Feb 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wking Feb 28, 2022

Choose a reason for hiding this comment

Uh oh!

jottofar Mar 1, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jottofar commented Mar 1, 2022

Uh oh!

jottofar commented Mar 3, 2022

Uh oh!

jottofar commented Mar 3, 2022

Uh oh!

jottofar commented Mar 4, 2022

Uh oh!

jottofar commented Mar 11, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wking Mar 11, 2022

Choose a reason for hiding this comment

Uh oh!

jottofar Mar 14, 2022

Choose a reason for hiding this comment

Uh oh!

wking Mar 14, 2022

Choose a reason for hiding this comment

Uh oh!

wking left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Mar 14, 2022

Uh oh!

openshift-ci bot commented Mar 14, 2022

Uh oh!

openshift-ci bot commented Mar 14, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jottofar commented Feb 21, 2022 •

edited

Loading