Automator: merge upstream changes to openshift-service-mesh/sail-operator@main#264
Merged
openshift-merge-bot[bot] merged 2 commits intoopenshift-service-mesh:mainfrom Feb 27, 2025
Conversation
* e2e multicluster test improve Signed-off-by: Francisco H <frherrer@redhat.com> Clean up multicluister test Signed-off-by: Francisco H <frherrer@redhat.com> Adding primary remote multicluster e2e test Signed-off-by: Francisco H <frherrer@redhat.com> Ensure e2e tests use the correct versions yaml file (openshift-service-mesh#667) We use `-ldflags` to set the `istioversion.versionsFilename` variable, but this only works when building the binary. It doesn't work when running ginkgo-based e2e tests. When the `versionsFilename` is not set via ldflags, it will now use the environment variable `VERSIONS_YAML_FILE`. If this env var isn't set, we default to `versions.yaml`. Signed-off-by: Marko Lukša <mluksa@redhat.com> Signed-off-by: Francisco H <frherrer@redhat.com> e2e multicluster test improve Signed-off-by: Francisco H <frherrer@redhat.com> Fix lint errors Signed-off-by: Francisco H <frherrer@redhat.com> Delete references to bookinfo on multicluster test Signed-off-by: Francisco H <frherrer@redhat.com> Fix change package on external multicluster test Signed-off-by: Francisco H <frherrer@redhat.com> * Apply suggestions from code review Co-authored-by: Nick Fox <6226732+nrfox@users.noreply.github.com> Signed-off-by: Francisco H <frherrer@redhat.com> * Changes from review Signed-off-by: Francisco H <frherrer@redhat.com> * More changes from review Signed-off-by: Francisco H <frherrer@redhat.com> * Add tag to common file in multicluster test Signed-off-by: Francisco H <frherrer@redhat.com> * Delete duplicated Label Signed-off-by: Francisco H <frherrer@redhat.com> --------- Signed-off-by: Francisco H <frherrer@redhat.com> Co-authored-by: Nick Fox <6226732+nrfox@users.noreply.github.com>
* upstream/main: External controlplane e2e test (openshift-service-mesh#676)
|
@openshift-service-mesh-bot: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated by Automator - 2025-02-27T18:05:03+00:00