Skip to content

Add migration docs for gateway-api gateways#263

Merged
openshift-merge-bot[bot] merged 2 commits intoopenshift-service-mesh:mainfrom
nrfox:gateway-api-migration-docs
Feb 27, 2025
Merged

Add migration docs for gateway-api gateways#263
openshift-merge-bot[bot] merged 2 commits intoopenshift-service-mesh:mainfrom
nrfox:gateway-api-migration-docs

Conversation

@nrfox
Copy link
Copy Markdown

@nrfox nrfox commented Feb 26, 2025

What type of PR is this?

  • Enhancement / New Feature
  • Bug Fix
  • Refactor
  • Optimization
  • Test
  • Documentation Update

What this PR does / why we need it:

Adds docs for migrating Gateway API Gateways

Which issue(s) this PR fixes:

Fixes #

Related Issue/PR #

Additional information:

Signed-off-by: Nick Fox <nfox@redhat.com>
@nrfox nrfox requested a review from FilipB February 26, 2025 18:18
@openshift-ci openshift-ci bot added the size/S label Feb 26, 2025

1. Label the `Gateway` resource to ensure injection from the new mesh is enabled (this differs between multitenancy and cluster-wide meshes), ensuring to add the `maistra.io/ignore` label as well as remove `istio-injection=enabled` if needed. For example:
```bash
oc label gateways.gateway.networking.k8s.io istio-ingress -n ${APP_NAMESPACE} istio.io/rev=${ISTIO_REVISION} maistra.io/ignore=""
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was testing with maistra.io/ignore=true but otherwise LGTM

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated with maistra.io/ignore="true"

Signed-off-by: Nick Fox <nfox@redhat.com>
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Feb 27, 2025

@nrfox: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ocp-4-18 34ce612 link false /test e2e-ocp-4-18

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@FilipB
Copy link
Copy Markdown

FilipB commented Feb 27, 2025

/override ci/prow/lint

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Feb 27, 2025

@FilipB: Overrode contexts on behalf of FilipB: ci/prow/lint

Details

In response to this:

/override ci/prow/lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 0cffa76 into openshift-service-mesh:main Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants