Skip to content

Conversation

@miguelsorianod
Copy link
Contributor

@miguelsorianod miguelsorianod commented Oct 16, 2025

This showcases the set of changes that will occur in the OCM SDK Go from the ARO-HCP CS split performed in openshift-online/ocm-api-model#1100.

This MR Is just a test MR. It should not be merged.

It should be safe to merge this for OCM Commercial, as this only modified aro-hcp data types.
For ARO-HCP, merging this will have an impact on the ARO-HCP RP: They will need to change the package of some data types to point to aro-hcp. This should be visible when they update the version of ocm-api-model and/or ocm-sdk-go. We evaluated the amount of changes and it is fairly small.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 16, 2025
@openshift-ci openshift-ci bot requested a review from cristianoveiga October 16, 2025 12:37
@openshift-ci
Copy link

openshift-ci bot commented Oct 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: miguelsorianod

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested a review from gdbranco October 16, 2025 12:37
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2025
@openshift-ci
Copy link

openshift-ci bot commented Oct 16, 2025

@miguelsorianod: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify f8b9ff4 link false /test verify

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@miguelsorianod
Copy link
Contributor Author

It seems the ci/prow/verify job is failing because of linting issues but they involve files that haven't been changed in this MR

@machi1990
Copy link
Contributor

It seems the ci/prow/verify job is failing because of linting issues but they involve files that haven't been changed in this MR

This seem to be failing since the PR #1085. And most of the recent PRs have been ignoring the failure.

There is a linting Github action that is passing https://github.com/openshift-online/ocm-sdk-go/actions/runs/18561491447/job/52911363527?pr=1090 so I guess we are safe to skip the failing check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants