Skip to content

Use kubeconfig option in cluster up message #1370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
creydr wants to merge 1 commit into from
Closed

Use kubeconfig option in cluster up message #1370

creydr wants to merge 1 commit into from

Conversation

@creydr
Copy link
Collaborator

@creydr creydr commented Mar 24, 2022

oc option --config does not exist.

$ oc --config <path> get no             
Error: unknown flag: --config
See 'oc get --help' for usage.

This PR addresses it and uses --kubeconfig in the cluster-up message instead.

@openshift-ci openshift-ci bot requested review from celebdor and zaneb March 24, 2022 09:58
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 24, 2022
@openshift-ci
Copy link

openshift-ci bot commented Mar 24, 2022

Hi @creydr. Thanks for your PR.

I'm waiting for a openshift-metal3 member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hardys
Copy link

hardys commented Mar 28, 2022

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 28, 2022
@hardys
Copy link

hardys commented Mar 28, 2022

/approve

Thanks for the fix!

@openshift-ci
Copy link

openshift-ci bot commented Mar 28, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hardys

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2022
@creydr
Copy link
Collaborator Author

creydr commented Mar 28, 2022

/retest

@creydr
Copy link
Collaborator Author

creydr commented Mar 28, 2022

/retest-required

@elfosardo
Copy link
Member

elfosardo commented Mar 29, 2022

/retest
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 29, 2022
@creydr
Copy link
Collaborator Author

creydr commented Mar 29, 2022

/retest-required

4 similar comments
@creydr
Copy link
Collaborator Author

creydr commented Mar 29, 2022

/retest-required

@creydr
Copy link
Collaborator Author

creydr commented Mar 30, 2022

/retest-required

@creydr
Copy link
Collaborator Author

creydr commented Mar 30, 2022

/retest-required

@creydr
Copy link
Collaborator Author

creydr commented Mar 31, 2022

/retest-required

@creydr
Copy link
Collaborator Author

creydr commented Mar 31, 2022

/retest

@creydr
Copy link
Collaborator Author

creydr commented Mar 31, 2022

/retest-required

6 similar comments
@creydr
Copy link
Collaborator Author

creydr commented Apr 1, 2022

/retest-required

@creydr
Copy link
Collaborator Author

creydr commented Apr 1, 2022

/retest-required

@creydr
Copy link
Collaborator Author

creydr commented Apr 4, 2022

/retest-required

@creydr
Copy link
Collaborator Author

creydr commented Apr 5, 2022

/retest-required

@creydr
Copy link
Collaborator Author

creydr commented Apr 5, 2022

/retest-required

@creydr
Copy link
Collaborator Author

creydr commented Apr 7, 2022

/retest-required

@creydr
Copy link
Collaborator Author

creydr commented Apr 7, 2022

/retest

@creydr
Copy link
Collaborator Author

creydr commented Apr 7, 2022

Seems e2e-metal-ipi-ovn-ipv6 is perma failing. Could someone with permissions do an /override to get this off the plate? :)
@hardys

@creydr
Copy link
Collaborator Author

creydr commented Apr 20, 2022

/retest

1 similar comment
@creydr
Copy link
Collaborator Author

creydr commented Apr 21, 2022

/retest

@openshift-ci
Copy link

openshift-ci bot commented Apr 22, 2022

@creydr: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-serial-ipv4 8bdce5a link true /test e2e-metal-ipi-serial-ipv4
ci/prow/e2e-metal-ipi 8bdce5a link true /test e2e-metal-ipi
ci/prow/e2e-metal-ipi-serial-ovn-ipv6 8bdce5a link true /test e2e-metal-ipi-serial-ovn-ipv6
ci/prow/e2e-metal-ipi-ovn-ipv6 8bdce5a link true /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-metal-ipi-proxy-ipv6 8bdce5a link true /test e2e-metal-ipi-proxy-ipv6
ci/prow/e2e-metal-ipi-proxy-ipv4 8bdce5a link true /test e2e-metal-ipi-proxy-ipv4

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@creydr
Copy link
Collaborator Author

creydr commented Apr 26, 2022

#1384 included this change too
/close

@openshift-ci
Copy link

openshift-ci bot commented Apr 26, 2022

@creydr: Closed this PR.

Details

In response to this:

#1384 included this change too
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot closed this Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@celebdor celebdor Awaiting requested review from celebdor

@zaneb zaneb Awaiting requested review from zaneb

Assignees

@elfosardo elfosardo

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@creydr @hardys @elfosardo