Skip to content

[release-4.7] Bug 2020694: Do not create systemd update-rps service for veth devices#774

Merged
openshift-merge-robot merged 1 commit into
openshift-kni:release-4.7from
openshift-cherrypick-robot:cherry-pick-667-to-release-4.7
Nov 8, 2021
Merged

[release-4.7] Bug 2020694: Do not create systemd update-rps service for veth devices#774
openshift-merge-robot merged 1 commit into
openshift-kni:release-4.7from
openshift-cherrypick-robot:cherry-pick-667-to-release-4.7

Conversation

@openshift-cherrypick-robot
Copy link
Copy Markdown

@openshift-cherrypick-robot openshift-cherrypick-robot commented Nov 5, 2021

This is an automated cherry-pick of #667

/assign MarSik

@openshift-merge-robot
Merge pull request openshift-kni#659 from cynepco3hahue/update_rps_oc…
d7ba8c8 
…i_hook

Bug 1967317: Do not create systemd update-rps service for veth devices

(cherry picked from commit 33b9640)
Signed-off-by: Artyom Lukianov <alukiano@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 5, 2021
Merged
@openshift-ci openshift-ci Bot requested review from ffromani and simon3z November 5, 2021 16:17
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Nov 5, 2021

@openshift-cherrypick-robot: Bugzilla bug 1975348 has been cloned as Bugzilla bug 2020694. Retitling PR to link against new bug.
/retitle [release-4.7] [release-4.8] Bug 2020694: Do not create systemd update-rps service for veth devices

Details

In response to this:

[release-4.7] [release-4.8] Bug 1975348: Do not create systemd update-rps service for veth devices

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot changed the title [release-4.7] [release-4.8] Bug 1975348: Do not create systemd update-rps service for veth devices [release-4.7] [release-4.8] Bug 2020694: Do not create systemd update-rps service for veth devices Nov 5, 2021
@openshift-ci openshift-ci Bot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Nov 5, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Nov 5, 2021

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2020694, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.z) matches configured target release for branch (4.7.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1975348 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1975348 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0, 4.8.z
  • bug has dependents

Requesting review from QA contact:
/cc @gsr-shanks

Details

In response to this:

[release-4.7] [release-4.8] Bug 2020694: Do not create systemd update-rps service for veth devices

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Nov 5, 2021
@MarSik MarSik changed the title [release-4.7] [release-4.8] Bug 2020694: Do not create systemd update-rps service for veth devices [release-4.7] Bug 2020694: Do not create systemd update-rps service for veth devices Nov 5, 2021
@openshift-ci openshift-ci Bot requested a review from gsr-shanks November 5, 2021 16:17
@coveralls
Copy link
Copy Markdown

coveralls commented Nov 5, 2021

Pull Request Test Coverage Report for Build 2037

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 73.133%
Totals Coverage Status
Change from base Build 1997: 0.0%
Covered Lines: 1048
Relevant Lines: 1433
💛 - Coveralls

@ffromani
Copy link
Copy Markdown
Member

ffromani commented Nov 8, 2021

/retest

@ffromani
Copy link
Copy Markdown
Member

ffromani commented Nov 8, 2021

/approve

@ffromani
Copy link
Copy Markdown
Member

ffromani commented Nov 8, 2021

/lgtm

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Nov 8, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fromanirh, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Nov 8, 2021
@cynepco3hahue
Copy link
Copy Markdown
Contributor

cynepco3hahue commented Nov 8, 2021

I think it affected by the same OLM bug that all previous versions affected.

@ffromani
Copy link
Copy Markdown
Member

ffromani commented Nov 8, 2021

I think it affected by the same OLM bug that all previous versions affected.

right, so we wait or we override :\

@cynepco3hahue
Copy link
Copy Markdown
Contributor

cynepco3hahue commented Nov 8, 2021

@fromanirh Let's wait for #776

@cynepco3hahue
Copy link
Copy Markdown
Contributor

cynepco3hahue commented Nov 8, 2021

/retest

@openshift-merge-robot openshift-merge-robot merged commit 7272fe1 into openshift-kni:release-4.7 Nov 8, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Nov 8, 2021

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 2020694 has been moved to the MODIFIED state.

Details

In response to this:

[release-4.7] Bug 2020694: Do not create systemd update-rps service for veth devices

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ffromani ffromani Awaiting requested review from ffromani

@simon3z simon3z Awaiting requested review from simon3z

@gsr-shanks gsr-shanks Awaiting requested review from gsr-shanks

Assignees

@MarSik MarSik

@ffromani ffromani

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@openshift-cherrypick-robot @coveralls @ffromani @cynepco3hahue @MarSik @openshift-merge-robot