Skip to content

[release-4.8] Bug 1975348: Do not create systemd update-rps service for veth devices#667

Merged
openshift-merge-robot merged 1 commit into
openshift-kni:release-4.8from
cynepco3hahue:release-4.8_update_rps_oci_hook
Jun 24, 2021
Merged

[release-4.8] Bug 1975348: Do not create systemd update-rps service for veth devices#667
openshift-merge-robot merged 1 commit into
openshift-kni:release-4.8from
cynepco3hahue:release-4.8_update_rps_oci_hook

Conversation

@cynepco3hahue
Copy link
Copy Markdown
Contributor

Bug 1967317: Do not create systemd update-rps service for veth devices

(cherry picked from commit 33b9640)
Signed-off-by: Artyom Lukianov alukiano@redhat.com

…i_hook

Bug 1967317: Do not create systemd update-rps service for veth devices

(cherry picked from commit 33b9640)
Signed-off-by: Artyom Lukianov <alukiano@redhat.com>
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 23, 2021

@cynepco3hahue: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

Merge pull request #659 from cynepco3hahue/update_rps_oci_hook

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot requested review from SchSeba and Tal-or June 23, 2021 13:24
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 23, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cynepco3hahue

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2021
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 1570

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 75.673%

Totals Coverage Status
Change from base Build 1568: 0.0%
Covered Lines: 1406
Relevant Lines: 1858

💛 - Coveralls

@cynepco3hahue cynepco3hahue changed the title Merge pull request #659 from cynepco3hahue/update_rps_oci_hook [release-4.8] Bug 1975348: Do not create systemd update-rps service for veth devices Jun 23, 2021
@openshift-ci openshift-ci Bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 23, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 23, 2021

@cynepco3hahue: This pull request references Bugzilla bug 1975348, which is invalid:

  • expected the bug to target the "4.8.0" release, but it targets "4.8.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.8] Bug 1975348: Do not create systemd update-rps service for veth devices

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cynepco3hahue
Copy link
Copy Markdown
Contributor Author

/bugzilla refresh

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 23, 2021

@cynepco3hahue: This pull request references Bugzilla bug 1975348, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1967317 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Bugzilla bug 1967317 targets the "4.9.0" release, which is one of the valid target releases: 4.9.0
  • bug has dependents

Requesting review from QA contact:
/cc @gsr-shanks

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 23, 2021
@openshift-ci openshift-ci Bot requested a review from gsr-shanks June 23, 2021 13:34
@ffromani
Copy link
Copy Markdown
Member

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2021
@openshift-merge-robot openshift-merge-robot merged commit cbdb661 into openshift-kni:release-4.8 Jun 24, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 24, 2021

@cynepco3hahue: All pull requests linked via external trackers have merged:

Bugzilla bug 1975348 has been moved to the MODIFIED state.

Details

In response to this:

[release-4.8] Bug 1975348: Do not create systemd update-rps service for veth devices

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MarSik
Copy link
Copy Markdown
Member

MarSik commented Nov 5, 2021

/cherry-pick release-4.7

@openshift-cherrypick-robot
Copy link
Copy Markdown

@MarSik: new pull request created: #774

Details

In response to this:

/cherry-pick release-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants