Fix configure_cm and remove unused functions#414
Merged
openshift-merge-robot merged 1 commit intoopenshift-knative:mainfrom Aug 14, 2023
Merged
Fix configure_cm and remove unused functions#414openshift-merge-robot merged 1 commit intoopenshift-knative:mainfrom
openshift-merge-robot merged 1 commit intoopenshift-knative:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nak3, ReToCode The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
configure_cmverifies the ConfigMaps inknative-servingnamespace. So, using the func forconfig-kourieris not correct.Also,
timeout()andconfigure_cm()are defined in SO so it is not necessary to implement it here.Which issue(s) this PR fixes:
NONE
Does this PR needs for other branches:
NONE.
Does this PR (patch) needs to update/drop in the future?:
NONE