Skip to content

[TEST_ONLY] Disable internal encryption and use kourier 1.11#408

Closed
nak3 wants to merge 6 commits intoopenshift-knative:release-nextfrom
nak3:disable-internal-encryption-kourier
Closed

[TEST_ONLY] Disable internal encryption and use kourier 1.11#408
nak3 wants to merge 6 commits intoopenshift-knative:release-nextfrom
nak3:disable-internal-encryption-kourier

Conversation

@nak3
Copy link

@nak3 nak3 commented Aug 4, 2023

/hold

@openshift-ci
Copy link

openshift-ci bot commented Aug 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Aug 4, 2023
@nak3
Copy link
Author

nak3 commented Aug 4, 2023

kourier 1.11 image needs kourier 1.11 manifest 😞

@nak3
Copy link
Author

nak3 commented Aug 4, 2023

And 1.11 manifest uses grpc probe so it does not work on OCP 4.10 😞

@nak3
Copy link
Author

nak3 commented Aug 7, 2023

Today, activator started getting another error:

I0807 01:59:59.638601       1 request.go:1097] Response Body: {"kind":"Status","apiVersion":"v1","metadata":{},"status":"Failure","message":"tokenreviews.authentication.k8s.io is forbidden: User \"system:serviceaccount:knative-serving:activator\" cannot create resource \"tokenreviews\" in API group \"authentication.k8s.io\" at the cluster scope","reason":"Forbidden","details":{"group":"authentication.k8s.io","kind":"tokenreviews"},"code":403}

@nak3
Copy link
Author

nak3 commented Aug 7, 2023

/retest

@nak3 nak3 changed the title [TEST_ONLY] Disable internal encryption kourier [TEST_ONLY] Disable internal encryption and use kourier 1.11 Aug 7, 2023
@nak3
Copy link
Author

nak3 commented Aug 7, 2023

/retest

@nak3 nak3 force-pushed the disable-internal-encryption-kourier branch from d57889d to 33534a3 Compare August 7, 2023 08:06
@nak3 nak3 force-pushed the disable-internal-encryption-kourier branch from 5e84502 to d81bdd6 Compare August 8, 2023 00:55
@nak3
Copy link
Author

nak3 commented Aug 8, 2023

/test 411-test-e2e-tls-aws-ocp-411

@nak3 nak3 force-pushed the disable-internal-encryption-kourier branch from 7555309 to 751a80f Compare August 8, 2023 01:58
@nak3
Copy link
Author

nak3 commented Aug 8, 2023

strange... The timeout change is not applied 🤔

@nak3
Copy link
Author

nak3 commented Aug 8, 2023

I see. Actually configure_cm in this repo is not used but SO repo's is used.

@nak3
Copy link
Author

nak3 commented Aug 8, 2023

/test 413-test-e2e-aws-ocp-413

infra - no cluster pool.

@nak3
Copy link
Author

nak3 commented Aug 8, 2023

/test 411-test-e2e-tls-aws-ocp-411

test ran but some of them failed.

@nak3
Copy link
Author

nak3 commented Aug 8, 2023

Some tests like TestAutoscaleSustaining started failing. TLS 1.3 may have a problem.

@nak3 nak3 force-pushed the disable-internal-encryption-kourier branch from b81cf79 to 017dae1 Compare August 9, 2023 01:32
@nak3 nak3 force-pushed the disable-internal-encryption-kourier branch 2 times, most recently from 92531ea to 32ffc83 Compare August 10, 2023 05:40
@nak3
Copy link
Author

nak3 commented Aug 10, 2023

Reverting these commits worked fine. So, one of them contains the issue..

@nak3 nak3 force-pushed the disable-internal-encryption-kourier branch from 34306fe to b31bfa7 Compare August 10, 2023 08:02
@nak3
Copy link
Author

nak3 commented Aug 10, 2023

most probably knative#14214 contains the issue.

@nak3 nak3 force-pushed the disable-internal-encryption-kourier branch 3 times, most recently from 451a8a9 to 9b23699 Compare August 11, 2023 05:17
@openshift-ci
Copy link

openshift-ci bot commented Aug 11, 2023

@nak3: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/410-test-e2e-aws-ocp-410 7a2e681 link true /test 410-test-e2e-aws-ocp-410
ci/prow/410-test-e2e-tls-aws-ocp-410 7a2e681 link true /test 410-test-e2e-tls-aws-ocp-410

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nak3 nak3 force-pushed the disable-internal-encryption-kourier branch from 9b23699 to 4d6c0ac Compare August 11, 2023 06:21
@openshift-ci
Copy link

openshift-ci bot commented Aug 11, 2023

/test remaining-required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants