Skip to content

[ART-10306] [ose-frr] set for_payload as true #5209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 1 commit into from
Aug 8, 2024
Merged

[ART-10306] [ose-frr] set for_payload as true #5209

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion images/ose-frr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ enabled_repos:
- rhel-9-appstream-rpms
- rhel-9-baseos-rpms
- rhel-9-server-ose-rpms-embargoed
for_payload: false
for_payload: true
dependents:
- ose-metallb-operator

@thegreyd thegreyd Aug 7, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we would also need to add cno as dependent i think

@thegreyd thegreyd Aug 7, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the related PR openshift/cluster-network-operator#2450

@ashwindasr ashwindasr Aug 7, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cluster-network-operator right?

@thegreyd thegreyd Aug 7, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm wait i'm wrong, dependent is a child image. but cno is not child image of frr

@thegreyd thegreyd Aug 7, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

parent/child isn't the best way to think about this.. I'll wait for confirmation

@Ximinhan Ximinhan Aug 8, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currently the dependents is more used for olm, the cluster-network-operator don't have olm yet, so it won't effect for now, we no need to add cluster-network-operator to dependents for now

@ashwindasr ashwindasr Aug 8, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ximin, updated

from:
Expand All @@ -22,6 +22,7 @@ from:
member: openshift-base-rhel9
name: openshift/frr-rhel9
name_in_bundle: metallb-frr-rhel9
payload_name: metallb-frr
owners:
- metallb-dev@redhat.com
non_shipping_repos:
Expand Down