[ART-10306] [ose-frr] set for_payload as true - #5209
Conversation
10e17c1 to
35c1904
Compare
| for_payload: false | ||
| for_payload: true | ||
| dependents: | ||
| - ose-metallb-operator |
There was a problem hiding this comment.
we would also need to add cno as dependent i think
There was a problem hiding this comment.
this is the related PR openshift/cluster-network-operator#2450
There was a problem hiding this comment.
cluster-network-operator right?
There was a problem hiding this comment.
hmm wait i'm wrong, dependent is a child image. but cno is not child image of frr
There was a problem hiding this comment.
parent/child isn't the best way to think about this.. I'll wait for confirmation
There was a problem hiding this comment.
currently the dependents is more used for olm, the cluster-network-operator don't have olm yet, so it won't effect for now, we no need to add cluster-network-operator to dependents for now
There was a problem hiding this comment.
Thanks ximin, updated
4f88da5 to
dbdf9fb
Compare
|
Setting payload name as |
|
/hold |
openshift-ci
Bot
added
the
do-not-merge/hold
dbdf9fb to
7598857
Compare
|
/unhold |
openshift-ci
Bot
removed
the
do-not-merge/hold
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashwindasr The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
/cherry-pick openshift-4.18 |
|
@ashwindasr: once the present PR merges, I will cherry-pick it on top of openshift-4.18 in a new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@ashwindasr: new pull request created: #5218 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
4 participants
ref https://issues.redhat.com/browse/ART-10306