Skip to content

Align Baremetal installer with upstream change#4596

Closed
thegreyd wants to merge 1 commit intoopenshift-eng:openshift-4.16from
thegreyd:remove_terraform_image
Closed

Align Baremetal installer with upstream change#4596
thegreyd wants to merge 1 commit intoopenshift-eng:openshift-4.16from
thegreyd:remove_terraform_image

Conversation

@thegreyd
Copy link
Contributor

@thegreyd thegreyd commented Apr 2, 2024

Should go after openshift/installer#8215

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 2, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from thegreyd. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thegreyd
Copy link
Contributor Author

thegreyd commented Apr 2, 2024

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 2, 2024
@openshift-bot
Copy link

Validating 1 file(s)...
Validating images/ose-baremetal-installer.yml...
✅ Validated images/ose-baremetal-installer.yml

@thegreyd
Copy link
Contributor Author

thegreyd commented Apr 2, 2024

Should go after openshift/installer#8215

@r4f4
Copy link

r4f4 commented Apr 2, 2024

@thegreyd so can I close #4583?

@r4f4
Copy link

r4f4 commented Apr 8, 2024

/hold cancel
Installer PR has merged.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 8, 2024
@r4f4
Copy link

r4f4 commented Apr 9, 2024

#4583 merged.
/close

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 9, 2024

@r4f4: You can't close an active issue/PR unless you authored it or you are a collaborator.

Details

In response to this:

#4583 merged.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@joepvd
Copy link
Contributor

joepvd commented Apr 9, 2024

/close

@openshift-ci openshift-ci bot closed this Apr 9, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 9, 2024

@joepvd: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants