Skip to content

ose-baremetal-installer does not depend on terraform-providers#4583

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift-eng:openshift-4.16from
r4f4:baremetal-installer-no-tf-image
Apr 9, 2024
Merged

ose-baremetal-installer does not depend on terraform-providers#4583
openshift-merge-bot[bot] merged 1 commit intoopenshift-eng:openshift-4.16from
r4f4:baremetal-installer-no-tf-image

Conversation

@r4f4
Copy link

@r4f4 r4f4 commented Mar 28, 2024

This is the only installer image that is dynamically built, so it needs to build the terraform providers as well since the terraform-providers image contains statically linked binaries.

/hold
for openshift/installer#8215

This is the only installer image that is dynamically built, so it needs
to build the terraform providers as well since the terraform-providers
image contains statically linked binaries.
@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 28, 2024
@openshift-bot
Copy link

Validating 1 file(s)...
Validating images/ose-baremetal-installer.yml...
✅ Validated images/ose-baremetal-installer.yml

Copy link
Contributor

@joepvd joepvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 9, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joepvd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 9, 2024
@joepvd
Copy link
Contributor

joepvd commented Apr 9, 2024

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 9, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 84085f7 into openshift-eng:openshift-4.16 Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants