fix(code-review): correct skill lookup paths in pre-commit-review - #610
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (5)
✅ Files skipped from review due to trivial changes (2)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThis PR updates plugin version metadata for ChangesPlugin metadata and docs
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 10✅ Passed checks (10 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
| "name": "openshift-developer", | ||
| "source": "./plugins/openshift-developer", | ||
| "description": "Bundle of curated plugins, skills, and MCP servers useful to any OpenShift engineer", | ||
| "version": "1.1.7", |
There was a problem hiding this comment.
please update the "dependencies": [
in openshift-developer plugin.json spec to drop the pinned version so it always get latest or it won't pull this change
cba2864 to
5c3bca9
Compare
|
/lgtm |
The pre-commit-review command looked for skill directories using `lang-<language>` and `profile-<name>` prefixes, but the actual directory names are `<language>-code-review` and `<name>-code-review`. Also bumps code-review to 0.0.12 and openshift-developer to 1.1.9 with updated dependency constraint. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
69be457 to
acf9ac2
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bryan-cox, enxebre The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary
pre-commit-reviewcommand that prevented language and profile skills from loadingskills/lang-<lang>/SKILL.mdandskills/profile-<name>/SKILL.md, but the actual directories areskills/<lang>-code-review/SKILL.mdandskills/<name>-code-review/SKILL.mdIssue
Discovered in periodic-jira-agent run 2074563553167151104 — the Phase 2 pre-commit review searched for
*pre-commit*,*lang-*, and*profile-*SKILL.md files but found none, causing the review to run without Go or HyperShift-specific guidance. See the transcript.Test plan
/code-review:pre-commit-review --language go --profile hypershiftand verify both skills load successfully🤖 Generated with Claude Code
Summary by CodeRabbit
Chores
code-reviewandopenshift-developerversions, including updatingopenshift-developer’scode-reviewdependency range.Documentation
code-review:pre-commit-reviewcommand guidance to use the new language and profile skill-file lookup paths.--profileargument description to match the updated path format.