Skip to content

fix(code-review): correct skill lookup paths in pre-commit-review - #610

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift-eng:mainfrom
bryan-cox:fix-pre-commit-review-skill-paths
Jul 7, 2026
Merged

openshift-merge-bot[bot] merged 1 commit into
openshift-eng:mainfrom
bryan-cox:fix-pre-commit-review-skill-paths

Conversation

@bryan-cox

@bryan-cox bryan-cox commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Fixed skill lookup paths in pre-commit-review command that prevented language and profile skills from loading
  • The command searched for skills/lang-<lang>/SKILL.md and skills/profile-<name>/SKILL.md, but the actual directories are skills/<lang>-code-review/SKILL.md and skills/<name>-code-review/SKILL.md
  • This caused the Go idioms and HyperShift conventions skills to silently fail to load during CI jira-agent runs

Issue

Discovered in periodic-jira-agent run 2074563553167151104 — the Phase 2 pre-commit review searched for *pre-commit*, *lang-*, and *profile-* SKILL.md files but found none, causing the review to run without Go or HyperShift-specific guidance. See the transcript.

Test plan

  • Run /code-review:pre-commit-review --language go --profile hypershift and verify both skills load successfully
  • Verify the jira-agent periodic job's Phase 2 (pre-commit review) picks up the Go and HyperShift skills

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores

    • Updated marketplace and plugin version metadata for the latest releases.
    • Bumped the code-review and openshift-developer versions, including updating openshift-developer’s code-review dependency range.
  • Documentation

    • Updated code-review:pre-commit-review command guidance to use the new language and profile skill-file lookup paths.
    • Adjusted the --profile argument description to match the updated path format.

@openshift-ci
openshift-ci Bot requested review from LuboTerifaj and stleerh July 7, 2026 19:41
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2026
@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 5bfce8e6-3aa4-4b3f-83c0-ac51d473ca9e

📥 Commits

Reviewing files that changed from the base of the PR and between 5c3bca9 and acf9ac2.

📒 Files selected for processing (5)
  • .claude-plugin/marketplace.json
  • docs/index.html
  • plugins/code-review/.claude-plugin/plugin.json
  • plugins/code-review/commands/pre-commit-review.md
  • plugins/openshift-developer/.claude-plugin/plugin.json
✅ Files skipped from review due to trivial changes (2)
  • plugins/code-review/.claude-plugin/plugin.json
  • docs/index.html
🚧 Files skipped from review as they are similar to previous changes (1)
  • .claude-plugin/marketplace.json

Walkthrough

This PR updates plugin version metadata for code-review and openshift-developer, and changes the documented skill-file lookup paths used by code-review:pre-commit-review.

Changes

Plugin metadata and docs

Layer / File(s) Summary
Release metadata
.claude-plugin/marketplace.json, docs/index.html, plugins/code-review/.claude-plugin/plugin.json, plugins/openshift-developer/.claude-plugin/plugin.json
Updates code-review to 0.0.12, updates openshift-developer to 1.1.9, and raises the code-review dependency constraint to ^0.0.12.
Pre-commit lookup paths
plugins/code-review/commands/pre-commit-review.md
Changes the documented --language and --profile skill lookup paths to skills/<value>-code-review/SKILL.md and updates the --profile <name> description accordingly.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

Suggested labels: lgtm

Suggested reviewers: bentito, mrunalp

🚥 Pre-merge checks | ✅ 10
✅ Passed checks (10 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: correcting code-review pre-commit skill lookup paths.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
No Real People Names In Style References ✅ Passed Changed command docs only update skill paths; no real-person names or style-reference examples appear in the modified hunks.
No Assumed Git Remote Names ✅ Passed The diff only updates versions and skill lookup paths; no added git commands or hardcoded remote-name assumptions appear.
Git Push Safety Rules ✅ Passed The PR only bumps versions and fixes skill-path docs; no git push, force-push, or main/master push instructions were added.
No Untrusted Mcp Servers ✅ Passed The PR only bumps existing plugin versions and a code-review dependency; no new MCP server install or dependency was introduced.
Ai-Helpers Overlap Detection ✅ Passed No other open PRs touch plugins/code-review; the only code-review change here is a path/version doc fix, not overlapping new functionality.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

"name": "openshift-developer",
"source": "./plugins/openshift-developer",
"description": "Bundle of curated plugins, skills, and MCP servers useful to any OpenShift engineer",
"version": "1.1.7",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update the "dependencies": [
in openshift-developer plugin.json spec to drop the pinned version so it always get latest or it won't pull this change

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@bryan-cox
bryan-cox force-pushed the fix-pre-commit-review-skill-paths branch from cba2864 to 5c3bca9 Compare July 7, 2026 19:53
@enxebre

enxebre commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

/lgtm

The pre-commit-review command looked for skill directories using
`lang-<language>` and `profile-<name>` prefixes, but the actual
directory names are `<language>-code-review` and `<name>-code-review`.

Also bumps code-review to 0.0.12 and openshift-developer to 1.1.9
with updated dependency constraint.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2026
@bryan-cox
bryan-cox force-pushed the fix-pre-commit-review-skill-paths branch from 69be457 to acf9ac2 Compare July 7, 2026 19:56
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2026
@enxebre

enxebre commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2026
@openshift-ci

openshift-ci Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit e9065e6 into openshift-eng:main Jul 7, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants