HPNEX-16: Add openshift-developer meta-plugin bundle - #502
Conversation
Curated bundle of plugins (jira, ci, golang, prodsec-skills) and MCP servers (Atlassian) for OpenShift engineers. Uses Claude Code plugin dependencies with semver constraints instead of a separate bundle directory structure. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
WalkthroughAdds an OpenShift Developer bundle: a plugin manifest declaring jira/ci/golang/prodsec-skills dependencies, marketplace registration, an atlassian MCP server config and policy allowlist, OWNERS governance, and installation documentation. ChangesOpenShift Developer Bundle Plugin
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 10✅ Passed checks (10 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
plugins/openshift-developer/commands/info.md (1)
1-6:⚠️ Potential issue | 🟠 Major | ⚡ Quick winAdd the required 4-phase overlap analysis report for
plugins/openshift-developer/commands/info.mdThe PR doesn’t include the mandated 4-phase overlap-check output.
- Phase 1 (relevant open PRs): the only open PR that touches this topic is
#502“Add openshift-developer meta-plugin bundle” (includesplugins/openshift-developer/apm.ymlandplugins/openshift-developer/commands/info.md); the other filtered open PRs are for unrelated plugins/skills.- Phase 2/3 (similarity): deep similarity against existing command/skill docs shows HIGH only for this file; other compared docs are LOW (< 0.60) with no other
openshift-developer/apm.yml/ meta-plugin matches.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@plugins/openshift-developer/commands/info.md` around lines 1 - 6, The file plugins/openshift-developer/commands/info.md is missing the required 4-phase overlap-analysis report; add a short section to this document that contains the four-phase overlap-check output: Phase 1 listing relevant open PRs (include PR `#502` “Add openshift-developer meta-plugin bundle” as the only PR touching this topic), Phase 2 and Phase 3 similarity results (state HIGH similarity only for this file and LOW (< 0.60) for other compared docs), and Phase 4 final conclusion summarizing there are no other conflicting meta-plugins or apm.yml matches; reference the plugin’s apm.yml and this info.md in the report so reviewers can verify the dependency list.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@plugins/openshift-developer/commands/info.md`:
- Around line 1-6: The file plugins/openshift-developer/commands/info.md is
missing the required 4-phase overlap-analysis report; add a short section to
this document that contains the four-phase overlap-check output: Phase 1 listing
relevant open PRs (include PR `#502` “Add openshift-developer meta-plugin bundle”
as the only PR touching this topic), Phase 2 and Phase 3 similarity results
(state HIGH similarity only for this file and LOW (< 0.60) for other compared
docs), and Phase 4 final conclusion summarizing there are no other conflicting
meta-plugins or apm.yml matches; reference the plugin’s apm.yml and this info.md
in the report so reviewers can verify the dependency list.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 5c4df365-a20f-48dc-916e-4d30f4332ebc
📒 Files selected for processing (7)
.claude-plugin/marketplace.jsondocs/index.htmlplugins/openshift-developer/.claude-plugin/plugin.jsonplugins/openshift-developer/OWNERSplugins/openshift-developer/README.mdplugins/openshift-developer/apm.ymlplugins/openshift-developer/commands/info.md
- Add Atlassian MCP server via .mcp.json for native Claude Code support - Add "bundle" category to marketplace entry - Remove apm.yml in favor of plugin.json dependencies - Update README to focus on Claude Code installation - Allowlist atlassian MCP server in skillsaw config Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@plugins/openshift-developer/commands/info.md`:
- Line 5: The overlap analysis is currently using global
`.claude-plugin/marketplace.json` and must be restricted to artifacts specific
to the openshift-developer bundle; update the overlap-check targets to only
include plugins/openshift-developer/plugin.json,
plugins/openshift-developer/.mcp.json and the bundle docs
plugins/openshift-developer/commands/info.md and
plugins/openshift-developer/README.md, exclude the global marketplace.json, then
re-run the mandated 4-phase overlap check (all phases) and re-bucket results
into HIGH/MODERATE/LOW based on matches against those targeted files only;
ensure any code/config referencing the previous global target is changed (search
for the overlap target list or function that builds targets) so the final
HIGH/MODERATE samples actually contain exact matches for the openshift-developer
artifacts named above.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: b42a6229-3e47-4ac5-bf1b-7e440151aed4
📒 Files selected for processing (6)
.claude-plugin/marketplace.json.skillsaw.yamldocs/index.htmlplugins/openshift-developer/.mcp.jsonplugins/openshift-developer/README.mdplugins/openshift-developer/commands/info.md
✅ Files skipped from review due to trivial changes (2)
- plugins/openshift-developer/.mcp.json
- plugins/openshift-developer/README.md
|
@stbenjam: This pull request references HPNEX-16 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
prodsec-skills has no git tags yet so version resolution fails. Keep it as an unversioned dependency. Document both marketplace registrations in the README. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bryan-cox, stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This is an example of a "meta-plugin" (bundle) that is a curated set, versioned, for an OpenShift engineer to install. Includes jira, ci, golang (from this marketplace) and prodsec-skills (cross-marketplace) as dependencies.
APM will work when microsoft/apm#1422 and microsoft/apm#1424 are merged, which will let the same plugin be used to target Cursor, OpenCode, etc.
Summary by CodeRabbit
New Features
Documentation