Skip to content

HPNEX-16: Add openshift-developer meta-plugin bundle - #502

Merged
openshift-merge-bot[bot] merged 4 commits into
openshift-eng:mainfrom
stbenjam:meta-plugins
May 26, 2026
Merged

openshift-merge-bot[bot] merged 4 commits into
openshift-eng:mainfrom
stbenjam:meta-plugins

Conversation

@stbenjam

@stbenjam stbenjam commented May 26, 2026

Copy link
Copy Markdown
Member

This is an example of a "meta-plugin" (bundle) that is a curated set, versioned, for an OpenShift engineer to install. Includes jira, ci, golang (from this marketplace) and prodsec-skills (cross-marketplace) as dependencies.

APM will work when microsoft/apm#1422 and microsoft/apm#1424 are merged, which will let the same plugin be used to target Cursor, OpenCode, etc.

Summary by CodeRabbit

  • New Features

    • Added OpenShift Developer bundle plugin with dependencies on Jira, CI, Go, and security skills plugins.
  • Documentation

    • Added installation documentation for the OpenShift Developer plugin via Claude Code and alternative editors.

Curated bundle of plugins (jira, ci, golang, prodsec-skills) and
MCP servers (Atlassian) for OpenShift engineers. Uses Claude Code
plugin dependencies with semver constraints instead of a separate
bundle directory structure.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@openshift-ci
openshift-ci Bot requested review from cblecker and theobarberbany May 26, 2026 19:17
@coderabbitai

coderabbitai Bot commented May 26, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: f39ff725-21ca-4800-be6d-86f8bb2de02e

📥 Commits

Reviewing files that changed from the base of the PR and between f7821f6 and c3778d2.

📒 Files selected for processing (2)
  • plugins/openshift-developer/.claude-plugin/plugin.json
  • plugins/openshift-developer/README.md
✅ Files skipped from review due to trivial changes (1)
  • plugins/openshift-developer/README.md

Walkthrough

Adds an OpenShift Developer bundle: a plugin manifest declaring jira/ci/golang/prodsec-skills dependencies, marketplace registration, an atlassian MCP server config and policy allowlist, OWNERS governance, and installation documentation.

Changes

OpenShift Developer Bundle Plugin

Layer / File(s) Summary
Plugin definition and dependencies
plugins/openshift-developer/.claude-plugin/plugin.json
The new openshift-developer bundle plugin declares metadata and dependencies on jira, ci, golang, and prodsec-skills with version/marketplace attribution.
Marketplace registration and cross-marketplace support
.claude-plugin/marketplace.json
Marketplace updated to allow prodsec-skills as a cross-marketplace dependency and adds an openshift-developer plugin entry (1.0.0, category bundle).
MCP server configuration and security allowlist
plugins/openshift-developer/.mcp.json, .skillsaw.yaml
Defines an atlassian HTTP MCP server (https://mcp.atlassian.com/v1/mcp) and adds atlassian to the .skillsaw.yaml allowlist.
Access control and installation documentation
plugins/openshift-developer/OWNERS, plugins/openshift-developer/README.md
Adds approvers/reviewers in OWNERS and documents the bundle contents, MCP server, and install steps (Claude plugin install and APM alternative).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested labels

lgtm

Suggested reviewers

  • theobarberbany
🚥 Pre-merge checks | ✅ 10
✅ Passed checks (10 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: adding an openshift-developer meta-plugin bundle, which aligns with all file additions and configurations in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
No Real People Names In Style References ✅ Passed No real people names found in style references, plugin commands, documentation, or example prompts in any PR files.
No Assumed Git Remote Names ✅ Passed The PR contains no hardcoded git remote names (origin/upstream) in commands, instructions, or documentation. The only "origin" reference is a plugin name in marketplace.json, not a git remote.
Git Push Safety Rules ✅ Passed PR adds only configuration and documentation files. No git push commands, force pushes, or autonomous push operations found in any changed files.
No Untrusted Mcp Servers ✅ Passed PR adds Atlassian Rovo MCP Server from https://mcp.atlassian.com/v1/mcp, an official Atlassian-hosted solution with OAuth 2.1 security and official Anthropic partnership—a trusted enterprise source.
Ai-Helpers Overlap Detection ✅ Passed PR adds only configuration and documentation files (plugin.json, .mcp.json, README.md); no command/skill/agent definitions present. Per check instructions, skip if only non-functional docs modified.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
plugins/openshift-developer/commands/info.md (1)

1-6: ⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Add the required 4-phase overlap analysis report for plugins/openshift-developer/commands/info.md

The PR doesn’t include the mandated 4-phase overlap-check output.

  • Phase 1 (relevant open PRs): the only open PR that touches this topic is #502 “Add openshift-developer meta-plugin bundle” (includes plugins/openshift-developer/apm.yml and plugins/openshift-developer/commands/info.md); the other filtered open PRs are for unrelated plugins/skills.
  • Phase 2/3 (similarity): deep similarity against existing command/skill docs shows HIGH only for this file; other compared docs are LOW (< 0.60) with no other openshift-developer / apm.yml / meta-plugin matches.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@plugins/openshift-developer/commands/info.md` around lines 1 - 6, The file
plugins/openshift-developer/commands/info.md is missing the required 4-phase
overlap-analysis report; add a short section to this document that contains the
four-phase overlap-check output: Phase 1 listing relevant open PRs (include PR
`#502` “Add openshift-developer meta-plugin bundle” as the only PR touching this
topic), Phase 2 and Phase 3 similarity results (state HIGH similarity only for
this file and LOW (< 0.60) for other compared docs), and Phase 4 final
conclusion summarizing there are no other conflicting meta-plugins or apm.yml
matches; reference the plugin’s apm.yml and this info.md in the report so
reviewers can verify the dependency list.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In `@plugins/openshift-developer/commands/info.md`:
- Around line 1-6: The file plugins/openshift-developer/commands/info.md is
missing the required 4-phase overlap-analysis report; add a short section to
this document that contains the four-phase overlap-check output: Phase 1 listing
relevant open PRs (include PR `#502` “Add openshift-developer meta-plugin bundle”
as the only PR touching this topic), Phase 2 and Phase 3 similarity results
(state HIGH similarity only for this file and LOW (< 0.60) for other compared
docs), and Phase 4 final conclusion summarizing there are no other conflicting
meta-plugins or apm.yml matches; reference the plugin’s apm.yml and this info.md
in the report so reviewers can verify the dependency list.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 5c4df365-a20f-48dc-916e-4d30f4332ebc

📥 Commits

Reviewing files that changed from the base of the PR and between 18b36cc and 7bfde88.

📒 Files selected for processing (7)
  • .claude-plugin/marketplace.json
  • docs/index.html
  • plugins/openshift-developer/.claude-plugin/plugin.json
  • plugins/openshift-developer/OWNERS
  • plugins/openshift-developer/README.md
  • plugins/openshift-developer/apm.yml
  • plugins/openshift-developer/commands/info.md

stbenjam and others added 2 commits May 26, 2026 15:28
- Add Atlassian MCP server via .mcp.json for native Claude Code support
- Add "bundle" category to marketplace entry
- Remove apm.yml in favor of plugin.json dependencies
- Update README to focus on Claude Code installation
- Allowlist atlassian MCP server in skillsaw config

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@plugins/openshift-developer/commands/info.md`:
- Line 5: The overlap analysis is currently using global
`.claude-plugin/marketplace.json` and must be restricted to artifacts specific
to the openshift-developer bundle; update the overlap-check targets to only
include plugins/openshift-developer/plugin.json,
plugins/openshift-developer/.mcp.json and the bundle docs
plugins/openshift-developer/commands/info.md and
plugins/openshift-developer/README.md, exclude the global marketplace.json, then
re-run the mandated 4-phase overlap check (all phases) and re-bucket results
into HIGH/MODERATE/LOW based on matches against those targeted files only;
ensure any code/config referencing the previous global target is changed (search
for the overlap target list or function that builds targets) so the final
HIGH/MODERATE samples actually contain exact matches for the openshift-developer
artifacts named above.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: b42a6229-3e47-4ac5-bf1b-7e440151aed4

📥 Commits

Reviewing files that changed from the base of the PR and between 7bfde88 and ecf1922.

📒 Files selected for processing (6)
  • .claude-plugin/marketplace.json
  • .skillsaw.yaml
  • docs/index.html
  • plugins/openshift-developer/.mcp.json
  • plugins/openshift-developer/README.md
  • plugins/openshift-developer/commands/info.md
✅ Files skipped from review due to trivial changes (2)
  • plugins/openshift-developer/.mcp.json
  • plugins/openshift-developer/README.md

Comment thread plugins/openshift-developer/commands/info.md Outdated
@stbenjam stbenjam changed the title Add openshift-developer meta-plugin bundle HPNEX-16: Add openshift-developer meta-plugin bundle May 26, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 26, 2026
@openshift-ci-robot

openshift-ci-robot commented May 26, 2026

Copy link
Copy Markdown

@stbenjam: This pull request references HPNEX-16 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

  • Adds openshift-developer plugin as a curated bundle of plugins, skills, and MCP servers for OpenShift engineers
  • Uses Claude Code plugin dependencies with semver constraints (^0.x.0)
  • Includes jira, ci, golang (from this marketplace) and prodsec-skills (cross-marketplace) as dependencies
  • Adds Atlassian MCP server via apm.yml
  • Also includes apm.yml for APM-based installs targeting other editors (e.g. Cursor via --target)

Test plan

  • Verify claude plugin install openshift-developer resolves all dependencies
  • Verify apm install openshift-eng/ai-helpers/plugins/openshift-developer --global works
  • Verify /openshift-developer:info command lists included packages
  • Confirm cross-marketplace resolution of prodsec-skills works

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features

  • Introduced OpenShift Developer plugin bundle for OpenShift engineers, including integrated Jira, CI, Golang, and security skills tools with Atlassian service integration.

  • Documentation

  • Added comprehensive documentation with installation instructions for the new OpenShift Developer bundle via Claude Code.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bryan-cox bryan-cox left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 26, 2026
prodsec-skills has no git tags yet so version resolution fails.
Keep it as an unversioned dependency. Document both marketplace
registrations in the README.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label May 26, 2026

@bryan-cox bryan-cox left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 26, 2026
@openshift-ci

openshift-ci Bot commented May 26, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants