ci:payload-analysis: drop command wrapper, let skill be invoked directly

[petr-muller]

The command file duplicated enough of the skill's content that the agent treated it as the full spec and never opened SKILL.md — observed in practice when RHCOS badges, variant isolation, and verbatim subagent prompts were all skipped.

Skills are directly invocable, so the command wrapper was unnecessary. Removing it eliminates the failure mode entirely. Examples and argument-hint migrated into SKILL.md.

🤖 Generated with Claude Code

Summary by CodeRabbit

• Documentation
  • Updated the payload-analysis skill documentation with a clearer directive for the required implementation steps.
  • Added an argument hint for the CLI invocation format and a new Examples section with practical usage scenarios.
• Chores
  • Bumped the CI plugin version to 0.0.49 consistently across marketplace metadata and the public docs/plugin manifests.

[coderabbitai]

Walkthrough

Enhances payload-analysis skill documentation with argument hints and three usage examples, adds an implementation directive to the command documentation, and bumps the ci plugin version from 0.0.48 to 0.0.49 across manifest, marketplace, and generated docs.

Changes

CI Plugin v0.0.49 Documentation and Release

Layer / File(s)	Summary
Payload-analysis skill documentation enhancements plugins/ci/skills/payload-analysis/SKILL.md	Adds argument-hint for the CLI invocation format and introduces an Examples section demonstrating three usage patterns: default nightly payload analysis, custom snapshot directory, and arm64-specific payload tag handling.
Implementation guidance and version release plugins/ci/commands/payload-analysis.md, plugins/ci/.claude-plugin/plugin.json, .claude-plugin/marketplace.json, docs/index.html	Inserts a directive in the command documentation requiring exact adherence to the skill implementation steps, and bumps the ci plugin version from 0.0.48 to 0.0.49 across the plugin manifest, marketplace metadata, and generated HTML docs.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• openshift-eng/ai-helpers#519: Updates to payload-analysis skill documentation alongside rhcos_version and variant-isolation work.
• openshift-eng/ai-helpers#355: Related guidance tightening and CI plugin metadata version bumps.

Suggested labels

lgtm

Suggested reviewers

• stbenjam
• zaneb

🚥 Pre-merge checks | ✅ 10

✅ Passed checks (10 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main objective: removing the command's step outline and requiring direct skill invocation instead.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
No Real People Names In Style References	✅ Passed	No real people names used as style references found. References to "Claude" are to the AI system/tool, not a person. "GitHub-inspired" refers to a platform's design, not a person.
No Assumed Git Remote Names	✅ Passed	This PR does not introduce any hardcoded git remote names. The modified files (SKILL.md with new examples, deleted command documentation, and version bumps) contain no git commands or remote name a...
Git Push Safety Rules	✅ Passed	The PR contains only documentation and metadata updates (version bumps in plugin.json files and markdown documentation). No git push commands, pushes to main/master, or force push operations are pr...
No Untrusted Mcp Servers	✅ Passed	PR does not introduce untrusted MCP servers. The ci plugin (this PR's scope) contains no MCP configs. Pre-existing MCP servers (gopls, atlassian) are from trusted sources and were not added by this...
Ai-Helpers Overlap Detection	✅ Passed	PR modifies existing payload-analysis skill/command (self-overlap only); no conflicts with other open PRs or duplicate functionality detected; per check instructions, defaults to silent pass.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[stbenjam]

We should drop this entire / command entirely, skils are / invocable.

[petr-muller]

good point, addressed

[stbenjam]

/test ?

[stbenjam]

/test eval-payload-analysis

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@plugins/ci/skills/payload-analysis/SKILL.md`:
- Around line 27-40: The three fenced code examples in the SKILL.md file are
missing language tags, which violates the markdownlint MD040 rule. Add the
`bash` language identifier to each of the three code fences containing the
`/ci:payload-analysis` commands (the nightly payload example, the snapshot
directory example, and the arm64 payload example) by changing each opening fence
from triple backticks to triple backticks followed by `bash`.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: c32a15d1-591d-4728-8020-f614b2788ad0

📥 Commits

Reviewing files that changed from the base of the PR and between 90ed221 and d2e1968.

📒 Files selected for processing (5)

• .claude-plugin/marketplace.json
• docs/index.html
• plugins/ci/.claude-plugin/plugin.json
• plugins/ci/commands/payload-analysis.md
• plugins/ci/skills/payload-analysis/SKILL.md

💤 Files with no reviewable changes (1)

• plugins/ci/commands/payload-analysis.md

🚧 Files skipped from review as they are similar to previous changes (1)

• plugins/ci/.claude-plugin/plugin.json

[stbenjam]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: petr-muller, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• plugins/ci/OWNERS [petr-muller,stbenjam]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment