More tenacious install analysis - #355
openshift-merge-bot[bot] merged 1 commit into
Conversation
…ysis Subagents investigating install failures must use the prow-job-analyze-install-failure skill to download and examine actual log bundles rather than making surface-level assessments based on pass rates or job names. Failure classifications must cite specific log lines or error messages. Also adds cross-job pattern recognition guidance (e.g., all techpreview jobs failing suggests a feature-set-specific bug) and emphasizes that all new PRs — including vendor-only rebases — should be evaluated as potential causes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
WalkthroughThis PR contains a version bump from 0.0.16 to 0.0.17 across the CI plugin and related documentation, along with updates to skill guidance documents that enhance install failure analysis procedures, introduce a new structured result format, and expand cross-job pattern recognition capabilities. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~13 minutes 🚥 Pre-merge checks | ✅ 8✅ Passed checks (8 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgoodwin, stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@plugins/ci/skills/analyze-payload/SKILL.md`:
- Around line 113-117: Update the “Install failure” and related guidance to
require attempting to download and examine the log bundle first, but explicitly
allow a documented fallback when no bundle artifact exists: change the
unconditional “MUST download and examine the actual installer log bundle”
wording so it mandates an attempt to fetch the bundle for the
ci:prow-job-analyze-install-failure flow and, if unavailable, instruct the
analyst to fall back to examining installer logs, bootstrap journals,
kube-apiserver logs, and JUnit/test logs and to record that the bundle was
missing; ensure the same fallback note is added to the metal-specific guidance
(ci:prow-job-analyze-metal-install-failure) and to the “Test failure” guidance
so classification is based on the best available logs with the absence of a
bundle explicitly documented.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 19bcd814-4646-4bdd-b05b-7fab151663e7
📒 Files selected for processing (6)
.claude-plugin/marketplace.jsondocs/data.jsonplugins/ci/.claude-plugin/plugin.jsonplugins/ci/skills/analyze-payload/SKILL.mdplugins/ci/skills/payload-agent/SKILL.mdplugins/ci/skills/prow-job-analyze-install-failure/SKILL.md
Subagents investigating install failures must use the prow-job-analyze-install-failure skill to download and examine actual log bundles rather than making surface-level assessments based on pass rates or job names. Failure classifications must cite specific log lines or error messages.
Also adds cross-job pattern recognition guidance (e.g., all techpreview jobs failing suggests a feature-set-specific bug) and emphasizes that all new PRs — including vendor-only rebases — should be evaluated as potential causes.
Summary by CodeRabbit
Chores
Documentation