Skip to content

More tenacious install analysis - #355

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift-eng:mainfrom
stbenjam:more-tenacious-install-analysis
Mar 4, 2026
Merged

openshift-merge-bot[bot] merged 1 commit into
openshift-eng:mainfrom
stbenjam:more-tenacious-install-analysis

Conversation

@stbenjam

@stbenjam stbenjam commented Mar 4, 2026

Copy link
Copy Markdown
Member

Subagents investigating install failures must use the prow-job-analyze-install-failure skill to download and examine actual log bundles rather than making surface-level assessments based on pass rates or job names. Failure classifications must cite specific log lines or error messages.

Also adds cross-job pattern recognition guidance (e.g., all techpreview jobs failing suggests a feature-set-specific bug) and emphasizes that all new PRs — including vendor-only rebases — should be evaluated as potential causes.

Summary by CodeRabbit

  • Chores

    • Bumped CI plugin version to 0.0.17
  • Documentation

    • Enhanced guidance for analyzing CI failures with emphasis on detailed log examination
    • Added structured result format for standardized failure analysis output
    • Improved documentation on log types and debugging workflows
    • Strengthened guidance on evaluating pull requests for feature-specific failures

…ysis

Subagents investigating install failures must use the
prow-job-analyze-install-failure skill to download and examine actual
log bundles rather than making surface-level assessments based on pass
rates or job names. Failure classifications must cite specific log
lines or error messages.

Also adds cross-job pattern recognition guidance (e.g., all techpreview
jobs failing suggests a feature-set-specific bug) and emphasizes that
all new PRs — including vendor-only rebases — should be evaluated as
potential causes.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-ci
openshift-ci Bot requested review from bentito and zaneb March 4, 2026 14:38
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2026
@coderabbitai

coderabbitai Bot commented Mar 4, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

This PR contains a version bump from 0.0.16 to 0.0.17 across the CI plugin and related documentation, along with updates to skill guidance documents that enhance install failure analysis procedures, introduce a new structured result format, and expand cross-job pattern recognition capabilities.

Changes

Cohort / File(s) Summary
Version Bumps
.claude-plugin/marketplace.json, docs/data.json, plugins/ci/.claude-plugin/plugin.json
Bumped CI plugin and triage-regression skill versions from 0.0.16 to 0.0.17 across marketplace configuration and documentation.
Skill Documentation Updates
plugins/ci/skills/analyze-payload/SKILL.md, plugins/ci/skills/payload-agent/SKILL.md, plugins/ci/skills/prow-job-analyze-install-failure/SKILL.md
Enhanced install failure analysis guidance with stricter log bundle requirements, introduced new ANALYSIS_RESULT structured response format (failure_type, root_cause_summary, affected_components, key_error_patterns, underlying_job_name), added cross-job pattern recognition guidance, reorganized Important Notes section with renumbered headings, and expanded File Formats subsection.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~13 minutes

🚥 Pre-merge checks | ✅ 8
✅ Passed checks (8 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'More tenacious install analysis' directly reflects the main change: strengthening install failure analysis by requiring log bundle examination and evidence-based classification across multiple files and skills.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
No Real People Names In Style References ✅ Passed Repository files were comprehensively searched for real people's names used as style references. No instances found in modified files or codebase.
No Assumed Git Remote Names ✅ Passed PR contains no hardcoded git remote names in modified files. Changes focus on version bumps and documentation updates only.
Git Push Safety Rules ✅ Passed All modified files contain no git push commands or variants; pre-push hook provides additional safety.
No Untrusted Mcp Servers ✅ Passed The PR only includes version bumps and documentation updates without introducing new MCP servers or untrusted dependencies.
Ai-Helpers Overlap Detection ✅ Passed The three modified skills form a complementary hierarchical workflow with distinct responsibilities and no semantic overlap exceeding 60% with existing repository skills.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@dgoodwin

dgoodwin commented Mar 4, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2026
@openshift-ci

openshift-ci Bot commented Mar 4, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@plugins/ci/skills/analyze-payload/SKILL.md`:
- Around line 113-117: Update the “Install failure” and related guidance to
require attempting to download and examine the log bundle first, but explicitly
allow a documented fallback when no bundle artifact exists: change the
unconditional “MUST download and examine the actual installer log bundle”
wording so it mandates an attempt to fetch the bundle for the
ci:prow-job-analyze-install-failure flow and, if unavailable, instruct the
analyst to fall back to examining installer logs, bootstrap journals,
kube-apiserver logs, and JUnit/test logs and to record that the bundle was
missing; ensure the same fallback note is added to the metal-specific guidance
(ci:prow-job-analyze-metal-install-failure) and to the “Test failure” guidance
so classification is based on the best available logs with the absence of a
bundle explicitly documented.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 19bcd814-4646-4bdd-b05b-7fab151663e7

📥 Commits

Reviewing files that changed from the base of the PR and between be6b182 and c906505.

📒 Files selected for processing (6)
  • .claude-plugin/marketplace.json
  • docs/data.json
  • plugins/ci/.claude-plugin/plugin.json
  • plugins/ci/skills/analyze-payload/SKILL.md
  • plugins/ci/skills/payload-agent/SKILL.md
  • plugins/ci/skills/prow-job-analyze-install-failure/SKILL.md

Comment thread plugins/ci/skills/analyze-payload/SKILL.md
@openshift-merge-bot
openshift-merge-bot Bot merged commit 93d2dbc into openshift-eng:main Mar 4, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants