Skip to content

MGMT-21086: Set TRANSPORT in template to streamable-http#59

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift-assisted:masterfrom
carbonin:use-streamable-http
Aug 8, 2025
Merged

MGMT-21086: Set TRANSPORT in template to streamable-http#59
openshift-merge-bot[bot] merged 1 commit intoopenshift-assisted:masterfrom
carbonin:use-streamable-http

Conversation

@carbonin
Copy link
Copy Markdown
Collaborator

@carbonin carbonin commented Aug 6, 2025

https://issues.redhat.com/browse/MGMT-21086

Merge with rh-ecosystem-edge/assisted-chat#92

Summary by CodeRabbit

  • Chores
    • Updated the default transport type setting to "streamable-http" for improved connectivity options.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 6, 2025
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Aug 6, 2025

@carbonin: This pull request references MGMT-21086 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set.

Details

In response to this:

https://issues.redhat.com/browse/MGMT-21086

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Aug 6, 2025

Walkthrough

The default value of the TRANSPORT parameter in template.yaml was updated from "sse" to "streamable-http". This parameter determines the MCP Server's transport type. No other modifications were made to the parameter or its usage.

Changes

Cohort / File(s) Change Summary
Parameter Default Update
template.yaml
Changed the default value of the TRANSPORT parameter from "sse" to "streamable-http".

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested labels

approved, size/S

Poem

A switch from SSE to streamable delight,
With one simple change, the future looks bright.
The MCP now streams with HTTP in tow—
A rabbit approves, with a hop and a glow!
🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2beef39 and 4f6361d.

📒 Files selected for processing (1)
  • template.yaml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Red Hat Konflux / assisted-service-mcp-saas-main-on-pull-request
🔇 Additional comments (1)
template.yaml (1)

43-45: Validate downstream compatibility of the new default transport value

Switching the default from "sse" to "streamable-http" changes the server-client protocol for every fresh install that doesn’t explicitly override TRANSPORT.
Before merging, please confirm:

  1. The container image referenced by ${IMAGE}:${IMAGE_TAG} already supports streamable-http end-to-end (handshake, framing, timeouts, etc.).
  2. All consumers (CLI, UI, automation) auto-detect the protocol or have been updated accordingly.
  3. No legacy environment assumes SSE by omission; if so, document the change in release notes.

If any of the above is uncertain, consider keeping the previous default and toggling via override until all components are aligned.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@openshift-ci openshift-ci Bot requested review from eranco74 and omertuc August 6, 2025 13:58
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Aug 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carbonin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 6, 2025
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Aug 6, 2025

@carbonin: This pull request references MGMT-21086 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set.

Details

In response to this:

https://issues.redhat.com/browse/MGMT-21086

Merge with rh-ecosystem-edge/assisted-chat#92

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Aug 6, 2025

@carbonin: This pull request references MGMT-21086 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set.

Details

In response to this:

https://issues.redhat.com/browse/MGMT-21086

Merge with rh-ecosystem-edge/assisted-chat#92

Summary by CodeRabbit

  • Chores
  • Updated the default transport type setting to "streamable-http" for improved connectivity options.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@eranco74
Copy link
Copy Markdown
Collaborator

eranco74 commented Aug 8, 2025

/lgtm
/hold
Unhold when you want it merged

@openshift-ci openshift-ci Bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Aug 8, 2025
@carbonin
Copy link
Copy Markdown
Collaborator Author

carbonin commented Aug 8, 2025

/unhold

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 8, 2025
@openshift-merge-bot openshift-merge-bot Bot merged commit 4bcb70a into openshift-assisted:master Aug 8, 2025
15 checks passed
@carbonin carbonin deleted the use-streamable-http branch August 8, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants