MGMT-21086: support different protocols by rccrdpccl · Pull Request #38 · openshift-assisted/assisted-service-mcp

rccrdpccl · 2025-07-22T11:21:05Z

Add the possibility to support different protocols.
We can set the env var TRANSPORT to "sse", "http" or "streamable-http".
The default path for sse is /sse and for streamable-http is /mcp

We kept the default to SSE to maintain the current behaviour.

Summary by CodeRabbit

Chores
- Updated the minimum required version of the fastmcp dependency.
- Improved internal naming consistency and updated import paths.
- Enhanced app initialization to support configurable transport protocol via environment variable.
- Refined token retrieval to improve header access.
- Updated tests to use client-based tool invocation and unified header mocking.
- Added a new deployment parameter to configure the transport protocol with default and allowed values.

openshift-ci-robot · 2025-07-22T11:21:08Z

@rccrdpccl: This pull request references MGMT-21086 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set.

Details

In response to this:

Add the possibility to support different protocols.
We can set the env var TRANSPORT to "sse", "http" or "streamable-http".
The default path for sse is /sse and for streamable-http is /mcp

We kept the default to SSE to maintain the current behaviour.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2025-07-22T11:21:12Z

Walkthrough

The changes update the fastmcp dependency version requirement in pyproject.toml and rename the MCP server instance variable in server.py from mcp to mcp_server. The import path for FastMCP is updated, header retrieval is refactored to use get_http_headers(), and app initialization now supports a configurable transport protocol via an environment variable. The test suite is refactored to mock headers directly and invoke tool functions through the fastmcp.Client interface.

Changes

File(s)	Change Summary
pyproject.toml	Updated `fastmcp` dependency requirement from `>=2.8.0` to `>=2.10.6`.
server.py	Renamed MCP instance variable to `mcp_server`, updated import paths, replaced header access with `get_http_headers()`, updated decorators, simplified `list_tools()`, added `get_transport()` function, and enabled transport configuration via environment variable.
tests/test_server.py	Refactored tests to mock `get_http_headers()` instead of MCP context/request headers and changed tool function calls to use `fastmcp.Client.call_tool()` within async context instead of direct calls.
template.yaml	Added `TRANSPORT` parameter with default `"sse"` and description; added `TRANSPORT` environment variable to container spec in the deployment.

Estimated code review effort

3 (~40 minutes)

Suggested labels

size/L

Poem

In the code garden where rabbits hop,
The MCP server got a name swap!
FastMCP’s path is shiny and new,
With transport options in the queue.
Tests now mock headers with care,
And call tools through clients fair.
🐇✨

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

openshift-ci-robot · 2025-07-22T11:23:21Z

@rccrdpccl: This pull request references MGMT-21086 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set.

Details

In response to this:

Add the possibility to support different protocols.
We can set the env var TRANSPORT to "sse", "http" or "streamable-http".
The default path for sse is /sse and for streamable-http is /mcp

We kept the default to SSE to maintain the current behaviour.

Summary by CodeRabbit

Chores

Updated the minimum required version of the fastmcp dependency.

Improved internal naming consistency and updated import paths.

Enhanced app initialization to support configurable transport protocol via environment variable.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai

Actionable comments posted: 4

🧹 Nitpick comments (1)

server.py (1)
546-549: Fix docstring formatting issue.

Remove the blank line after the docstring to satisfy pydocstyle requirements.
 def list_tools() -> list[str]:
     """List all MCP tools."""
-
     tools = asyncio.run(mcp_server.get_tools())
     return list(tools.keys())

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d7fb34d and 101abcb.

⛔ Files ignored due to path filters (1)

uv.lock is excluded by !**/*.lock

📒 Files selected for processing (2)

pyproject.toml (1 hunks)
server.py (17 hunks)

🪛 GitHub Actions: Black

server.py

[error] 1-1: Black formatting check failed. The file would be reformatted. Run 'black server.py' to fix code style issues.

🪛 GitHub Actions: Pydocstyle

server.py

[error] 547-547: pydocstyle D202: No blank lines allowed after function docstring (found 1) in public function list_tools.

🪛 GitHub Actions: Python linter

server.py

[error] 67-67: pylint E1101: Instance of 'FastMCP' has no 'get_context' member (no-member)

[error] 94-94: pylint E1101: Instance of 'FastMCP' has no 'get_context' member (no-member)

[error] 34-34: pylint E1101: Module 'server' has no 'mcp' member (no-member)

[error] 95-95: pylint E1101: Module 'server' has no 'mcp' member (no-member)

[error] 224-224: pylint E1101: Module 'server' has no 'mcp' member (no-member)

🪛 GitHub Actions: Unit Tests

server.py

[error] 34-34: AttributeError: module 'server' has no attribute 'mcp' at setup of multiple TestTokenFunctions tests.

[error] 95-95: AttributeError: module 'server' has no attribute 'mcp' in test_get_offline_token_no_request.

[error] 224-224: AttributeError: module 'server' has no attribute 'mcp' in test_get_access_token_no_request_context.

[error] 265-265: TypeError: 'FunctionTool' object is not callable in test_cluster_info_success.

[error] 298-298: TypeError: 'FunctionTool' object is not callable in test_list_clusters_success.

[error] 318-318: TypeError: 'FunctionTool' object is not callable in test_cluster_events_success.

[error] 340-340: TypeError: 'FunctionTool' object is not callable in test_host_events_success.

[error] 370-370: TypeError: 'FunctionTool' object is not callable in test_cluster_iso_download_url_success.

[error] 424-424: TypeError: 'FunctionTool' object is not callable in test_cluster_iso_download_url_multiple_infraenvs.

[error] 464-464: TypeError: 'FunctionTool' object is not callable in test_cluster_iso_download_url_no_expiration.

[error] 496-496: TypeError: 'FunctionTool' object is not callable in test_cluster_iso_download_url_zero_expiration.

[error] 519-519: TypeError: 'FunctionTool' object is not callable in test_cluster_iso_download_url_no_infraenvs.

[error] 552-552: TypeError: 'FunctionTool' object is not callable in test_create_cluster_success.

[error] 581-581: TypeError: 'FunctionTool' object is not callable in test_set_cluster_vips_success.

[error] 602-602: TypeError: 'FunctionTool' object is not callable in test_install_cluster_success.

[error] 620-620: TypeError: 'FunctionTool' object is not callable in test_list_versions_success.

[error] 642-642: TypeError: 'FunctionTool' object is not callable in test_list_operator_bundles_success.

[error] 664-664: TypeError: 'FunctionTool' object is not callable in test_add_operator_bundle_to_cluster_success.

[error] 690-690: TypeError: 'FunctionTool' object is not callable in test_set_host_role_success.

[error] 715-715: TypeError: 'FunctionTool' object is not callable in test_cluster_credentials_download_url_success.

[error] 743-743: TypeError: 'FunctionTool' object is not callable in test_cluster_credentials_download_url_no_expiration.

[error] 773-773: TypeError: 'FunctionTool' object is not callable in test_cluster_credentials_download_url_zero_expiration.

🪛 GitHub Actions: Type checks

server.py

[error] 21-21: mypy: Need type annotation for "mcp_server" [var-annotated]

[error] 549-549: mypy: Argument 1 to "run" has incompatible type "Coroutine[Any, Any, dict[str, Tool]]"; expected "Coroutine[Any, Any, list[str]]" [arg-type]

[error] 554-554: mypy: Argument "transport" to "http_app" of "FastMCP" has incompatible type "str"; expected "Literal['http', 'streamable-http', 'sse']" [arg-type]

[error] 265-265: mypy: "FunctionTool" not callable [operator]

[error] 298-298: mypy: "FunctionTool" not callable [operator]

[error] 318-318: mypy: "FunctionTool" not callable [operator]

[error] 340-340: mypy: "FunctionTool" not callable [operator]

[error] 370-370: mypy: "FunctionTool" not callable [operator]

[error] 424-424: mypy: "FunctionTool" not callable [operator]

[error] 464-464: mypy: "FunctionTool" not callable [operator]

[error] 496-496: mypy: "FunctionTool" not callable [operator]

[error] 519-519: mypy: "FunctionTool" not callable [operator]

[error] 552-552: mypy: "FunctionTool" not callable [operator]

[error] 581-581: mypy: "FunctionTool" not callable [operator]

[error] 602-602: mypy: "FunctionTool" not callable [operator]

[error] 620-620: mypy: "FunctionTool" not callable [operator]

[error] 642-642: mypy: "FunctionTool" not callable [operator]

[error] 664-664: mypy: "FunctionTool" not callable [operator]

[error] 690-690: mypy: "FunctionTool" not callable [operator]

[error] 715-715: mypy: "FunctionTool" not callable [operator]

[error] 743-743: mypy: "FunctionTool" not callable [operator]

[error] 773-773: mypy: "FunctionTool" not callable [operator]

🪛 GitHub Actions: Pyright

server.py

[error] 67-67: Cannot access attribute "get_context" for class "FastMCP[Unknown]" (reportAttributeAccessIssue)

[error] 94-94: Cannot access attribute "get_context" for class "FastMCP[Unknown]" (reportAttributeAccessIssue)

[error] 549-549: Type "dict[str, Tool]" is not assignable to return type "list[str]" (reportReturnType)

[error] 554-554: Argument of type "str" cannot be assigned to parameter "transport" of type "Literal['http', 'streamable-http', 'sse']" in function "http_app" (reportArgumentType)

[error] 34-34: "mcp" is not a known attribute of module "server" (reportAttributeAccessIssue)

[error] 95-95: "mcp" is not a known attribute of module "server" (reportAttributeAccessIssue)

[error] 224-224: "mcp" is not a known attribute of module "server" (reportAttributeAccessIssue)

[error] 265-265: Object of type "FunctionTool" is not callable; Attribute "call" is unknown (reportCallIssue)

[error] 298-298: Object of type "FunctionTool" is not callable; Attribute "call" is unknown (reportCallIssue)

[error] 318-318: Object of type "FunctionTool" is not callable; Attribute "call" is unknown (reportCallIssue)

[error] 340-340: Object of type "FunctionTool" is not callable; Attribute "call" is unknown (reportCallIssue)

[error] 370-370: Object of type "FunctionTool" is not callable; Attribute "call" is unknown (reportCallIssue)

[error] 424-424: Object of type "FunctionTool" is not callable; Attribute "call" is unknown (reportCallIssue)

[error] 464-464: Object of type "FunctionTool" is not callable; Attribute "call" is unknown (reportCallIssue)

[error] 496-496: Object of type "FunctionTool" is not callable; Attribute "call" is unknown (reportCallIssue)

[error] 519-519: Object of type "FunctionTool" is not callable; Attribute "call" is unknown (reportCallIssue)

[error] 552-552: Object of type "FunctionTool" is not callable; Attribute "call" is unknown (reportCallIssue)

[error] 581-581: Object of type "FunctionTool" is not callable; Attribute "call" is unknown (reportCallIssue)

[error] 602-602: Object of type "FunctionTool" is not callable; Attribute "call" is unknown (reportCallIssue)

[error] 620-620: Object of type "FunctionTool" is not callable; Attribute "call" is unknown (reportCallIssue)

[error] 642-642: Object of type "FunctionTool" is not callable; Attribute "call" is unknown (reportCallIssue)

[error] 664-664: Object of type "FunctionTool" is not callable; Attribute "call" is unknown (reportCallIssue)

[error] 690-690: Object of type "FunctionTool" is not callable; Attribute "call" is unknown (reportCallIssue)

[error] 715-715: Object of type "FunctionTool" is not callable; Attribute "call" is unknown (reportCallIssue)

[error] 743-743: Object of type "FunctionTool" is not callable; Attribute "call" is unknown (reportCallIssue)

[error] 773-773: Object of type "FunctionTool" is not callable; Attribute "call" is unknown (reportCallIssue)

🧰 Additional context used