Skip to content

OCPBUGS-74421 | OVE UI: Fix rendezvousIP field name in error message #3375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
asmasarw wants to merge 2 commits into from
Closed

OCPBUGS-74421 | OVE UI: Fix rendezvousIP field name in error message #3375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
997c357
OCPBUGS-72598 | [OVE] Custom manifests are broken in local Assisted UI
asmasarw Feb 1, 2026
cb4d0ca
Add Translations for ai:Rendezvous IP to show in UpperCase
asmasarw Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions libs/locales/lib/en/translation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -748,6 +748,7 @@
"ai:Removing from cluster": "Removing from cluster",
"ai:Rename hostnames using the custom template:": "Rename hostnames using the custom template:",
"ai:Rendezvous IP": "Rendezvous IP",
"ai:RendezvousIP": "RendezvousIP",
"ai:Report a bug": "Report a bug",
"ai:Required field": "Required field",
"ai:Requirements for Two Node control plane OpenShift": "Requirements for Two Node control plane OpenShift",
Expand Down
1 change: 1 addition & 0 deletions libs/ui-lib/lib/common/config/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ export const clusterFieldLabels = (t: TFunction): { [key in string]: string } =>
machineNetworks: t('ai:Machine networks'),
clusterNetworks: t('ai:Cluster networks'),
serviceNetworks: t('ai:Service networks'),
rendezvousIp: t('ai:RendezvousIP'),
});

export const hostValidationGroupLabels = (
Expand Down
8 changes: 6 additions & 2 deletions libs/ui-lib/lib/ocm/components/clusterWizard/ClusterWizardContextProvider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,10 +160,14 @@ const ClusterWizardContextProvider = ({
isSingleClusterFeatureEnabled,
);

// Only move step if there is still none, or the user is at a forbidden step
// Only move step if there is still none, or the user is at a forbidden step.
// Never force the user off the custom-manifests step when they are actively filling it
// (e.g. after pasting content triggers auto-save and uiSettings can update).
if (
!currentStepId ||
(customManifestsStepNeedsToBeFilled && isStepAfter(currentStepId, requiredStepId))
(currentStepId !== 'custom-manifests' &&
customManifestsStepNeedsToBeFilled &&
isStepAfter(currentStepId, requiredStepId))
) {
setCurrentStepId(requiredStepId);
}
Expand Down
Loading