OCPBUGS-74421 | OVE UI: Fix rendezvousIP field name in error message

[asmasarw]

OVE UI: Fix rendezvousIP field name in error message

Summary by CodeRabbit

• New Features

  • Added RendezvousIP field to cluster configuration labels.

• Bug Fixes

  • Fixed cluster wizard to prevent auto-advancing from the custom manifests step while actively filling it out.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: asmasarw
Once this PR has been reviewed and has the lgtm label, please assign batzionb for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

📝 Walkthrough

Walkthrough

The PR adds a translation key for "RendezvousIP", introduces a corresponding label mapping in the cluster field labels configuration, and modifies the cluster wizard context provider guard condition to prevent auto-advancing from the custom-manifests step while users are actively filling it.

Changes

Cohort / File(s)	Summary
Localization libs/locales/lib/en/translation.json	Added translation key ai:RendezvousIP mapping to "RendezvousIP".
Configuration libs/ui-lib/lib/common/config/constants.ts	Added rendezvousIp property to the clusterFieldLabels configuration, referencing the new translation key.
Wizard Logic libs/ui-lib/lib/ocm/components/clusterWizard/ClusterWizardContextProvider.tsx	Modified guard condition to prevent auto-advancing away from custom-manifests step when customManifestsStepNeedsToBeFilled is true and currentStepId is 'custom-manifests'.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

• MGMT-22465: Merge the contents of releases/v2.17-cim into master #3319: Introduces the custom-manifests wizard step, translations, and UI wiring that this PR builds upon by improving the step navigation logic.

Suggested labels

lgtm, approved, size/XS, jira/valid-bug, jira/valid-reference

Suggested reviewers

• jgyselov
• ammont82
• batzionb

Poem

🐰 A rendezvous awaits in code so clean,
With labels mapped and translations keen,
The wizard now keeps steady pace,
No premature steps in this space! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The title references fixing the rendezvousIP field name in error messages, but the actual changes add a new translation key and label mapping without modifying error message logic, and include unrelated changes to custom manifests step guard conditions.	Update the title to accurately reflect all changes, such as 'Add rendezvousIP label and translation key with custom manifests step fix' or clarify the scope to match actual implementation.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[asmasarw]

Invalid PR