Skip to content

AGENT-1435: Update featureSet to TechPreviewNoUpgrade#3371

Closed
pawanpinjarkar wants to merge 1 commit intomasterfrom
update-featureset-to-TechPreviewNoUpgrade
Closed

AGENT-1435: Update featureSet to TechPreviewNoUpgrade#3371
pawanpinjarkar wants to merge 1 commit intomasterfrom
update-featureset-to-TechPreviewNoUpgrade

Conversation

@pawanpinjarkar
Copy link
Contributor

@pawanpinjarkar pawanpinjarkar commented Jan 28, 2026

Summary by CodeRabbit

  • Bug Fixes
    • Fixed network configuration to properly apply the technical preview feature set for single-cluster deployments instead of the custom option, ensuring correct system behavior.

✏️ Tip: You can customize this high-level summary in your review settings.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 28, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 28, 2026

@pawanpinjarkar: This pull request references AGENT-1435 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from LiorSoffer and asmasarw January 28, 2026 19:40
@openshift-ci
Copy link

openshift-ci bot commented Jan 28, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pawanpinjarkar
Once this PR has been reviewed and has the lgtm label, please assign ammont82 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 28, 2026
@coderabbitai
Copy link

coderabbitai bot commented Jan 28, 2026

📝 Walkthrough

Walkthrough

The PR modifies the single-cluster feature flow in NetworkConfigurationForm to update the install config's featureSet parameter from CustomNoUpgrade to TechPreviewNoUpgrade when making the ClustersAPI.updateInstallConfig call, preserving all other behavior.

Changes

Cohort / File(s) Summary
Single-cluster install config update
libs/ui-lib/lib/ocm/components/clusterConfiguration/networkConfiguration/NetworkConfigurationForm.tsx
Changed featureSet value from CustomNoUpgrade to TechPreviewNoUpgrade in the updateInstallConfig API call within the onNext flow when single-cluster feature is enabled

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested labels

lgtm, approved, size/XS

Suggested reviewers

  • ammont82
  • rawagner
  • asmasarw

Poem

🐰 A hop through the configs so fine,
From CustomNoUpgrade to TechPreview divine,
One line adjusted with elegant grace,
The feature set finds its rightful place! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: updating featureSet to TechPreviewNoUpgrade. It is concise, directly related to the primary modification in the changeset, and includes an issue reference (AGENT-1435) for context.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pawanpinjarkar
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 28, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 28, 2026

@pawanpinjarkar: This pull request references AGENT-1435 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Summary by CodeRabbit

  • Bug Fixes
  • Fixed network configuration to properly apply the technical preview feature set for single-cluster deployments instead of the custom option, ensuring correct system behavior.

✏️ Tip: You can customize this high-level summary in your review settings.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pawanpinjarkar
Copy link
Contributor Author

Closing this PR as the change needs to be configurable via CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants