Skip to content

[Backport 2.x] Add maketime and makedate datetime functions #769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
opensearch-trigger-bot wants to merge 1 commit into from
Closed

[Backport 2.x] Add maketime and makedate datetime functions #769

opensearch-trigger-bot wants to merge 1 commit into from

Conversation

@opensearch-trigger-bot
Copy link
Contributor

@opensearch-trigger-bot opensearch-trigger-bot bot commented Aug 17, 2022

Backport 9f602c3 from #755

@Yury-Fridlyand @github-actions
Add maketime and makedate (#102) (#755)
96f10bf 
Signed-off-by: Yury Fridlyand <[email protected]>

Signed-off-by: Yury Fridlyand <[email protected]>
(cherry picked from commit 9f602c3)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner August 17, 2022 16:23
@dai-chen
Copy link
Collaborator

dai-chen commented Aug 17, 2022

I just merged the backport PR #761 for Workbench failure.

@dai-chen
Copy link
Collaborator

dai-chen commented Aug 17, 2022

DCO failed due to : "Can not find "Yury-Fridlyand [email protected]", in ["Yury Fridlyand [email protected]", "Yury Fridlyand [email protected]"]"

@Yury-Fridlyand
Copy link
Collaborator

Yury-Fridlyand commented Aug 17, 2022

Damn again, I'm going to hate DCO!

@dai-chen
Copy link
Collaborator

dai-chen commented Aug 17, 2022

Damn again, I'm going to hate DCO!

I ran into similar problem recently on backport PR and found my Github no-reply email was used in my previous commit :(

@joshuali925
Copy link
Member

joshuali925 commented Aug 17, 2022

i think for backport PRs it's ok, just make sure your local git config user.name and user.email is consistent with github settings displayed name and email so future backports DCO won't fail. i explained a bit in #706 (comment)

@penghuo
Copy link
Collaborator

penghuo commented Aug 17, 2022

Covered by https://github.com/opensearch-project/sql/pull/771/commits.

@penghuo penghuo closed this Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshuali925 joshuali925 joshuali925 approved these changes

@dai-chen dai-chen dai-chen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dai-chen @Yury-Fridlyand @joshuali925 @penghuo