Add maketime and makedate datetime functions

[Yury-Fridlyand]

Signed-off-by: Yury Fridlyand [email protected]

Description

• maketime, references: one two
  • Supports any values in range 00:00:00.0 - 23:59:59.(9);
  • All arguments are double, but hour and minute are rounded (as MySQL works);
  • Fraction second part is kept;
  • NULL values causes NULL result;
  • Unlike MySQL, negative values, and hour > 23 are not supported. Implementation of that requires big changes.
• makedate, references one two
  • All arguments are double, but rounded (as MySQL works);
  • Zero year interpreted as 2000 (as MySQL works);
  • NULL values causes NULL result;
  • day < 1 causes NULL result;
  • day > 365/366 causes switching to the next year.

Implementation details

Functions have 2 implementations:

• easier
• faster

I used easier one, but faster one used in unit tests. Could be swapped.

According to MySQL both functions accept double values. Arguments which are not supposed to have fraction parts (e.g. hour, year) are rounded.

maketime doesn't support range of +-838 hours, it is limited by 24 hour clock time. Implementation of that requires big changes.

Issues Resolved

#722

Check List

• New functionality includes testing.
  • All tests pass, including unit test, integration test and doctest
• New functionality has been documented.
  • New functionality has javadoc added
  • New functionality has user manual doc added
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.84%. Comparing base (deececb) to head (00a2dca).
⚠️ Report is 1057 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main     #755      +/-   ##
============================================
+ Coverage     94.83%   94.84%   +0.01%     
- Complexity     2898     2908      +10     
============================================
  Files           287      287              
  Lines          7803     7825      +22     
  Branches        568      571       +3     
============================================
+ Hits           7400     7422      +22     
  Misses          349      349              
  Partials         54       54              

Flag	Coverage Δ
query-workbench	62.76% <ø> (ø)
sql-engine	97.79% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[dai-chen]

Could you rebase your branch? There seems many irrelevant changes from previous commit. Thanks!

[Yury-Fridlyand]

Could you rebase your branch? There seems many irrelevant changes from previous commit. Thanks!

Should be ok now.

[dai-chen]

Thanks for the changes!