Minor documentation update #718
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Callout distinction between original and current SQL engines. Signed-off-by: Max Ksyunz <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #718 +/- ##
=============================================
- Coverage 94.75% 62.76% -31.99%
=============================================
Files 283 10 -273
Lines 7678 658 -7020
Branches 560 118 -442
=============================================
- Hits 7275 413 -6862
+ Misses 349 192 -157
+ Partials 54 53 -1
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
joshuali925
previously approved these changes
Aug 1, 2022
dai-chen
previously approved these changes
Aug 2, 2022
Collaborator
dai-chen
left a comment
dai-chen
left a comment
There was a problem hiding this comment.
Minor comment. Thanks for the changes!
Signed-off-by: MaxKsyunz <[email protected]>
joshuali925
approved these changes
Aug 4, 2022
dai-chen
approved these changes
Aug 4, 2022
Collaborator
Author
|
Please see #728 -- same change, but with passing DCO check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Callout distinction between original and current SQL engines.
Signed-off-by: Max Ksyunz [email protected]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.