Skip to content

Conversation

@MaxKsyunz
Copy link

Description

Note the distinction between original and current SQL engines

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

❗ No coverage uploaded for pull request base (integ-doc-sql-ver-note@592c58b). Click here to learn what that means.
The diff coverage is n/a.

@@                    Coverage Diff                    @@
##             integ-doc-sql-ver-note      #93   +/-   ##
=========================================================
  Coverage                          ?   97.75%           
  Complexity                        ?     2859           
=========================================================
  Files                             ?      273           
  Lines                             ?     7029           
  Branches                          ?      444           
=========================================================
  Hits                              ?     6871           
  Misses                            ?      157           
  Partials                          ?        1           
Flag Coverage Δ
sql-engine 97.75% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us.

@MaxKsyunz MaxKsyunz requested a review from a team July 26, 2022 16:41

Full-text search is for searching a single stored document which is distinguished from regular search based on original texts in database. It tries to match search criteria by examining all of the words in each document. In OpenSearch, full-text queries provided enables you to search text fields analyzed during indexing.

This document describes the original SQL engine. It only applies to queries that are not handled by the current SQL engine. Documentation for the current engine can be found `here <../dql/functions.rst#relevance>`_.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just thinking we could use slightly more accurate wording here, is this better?
It only applies to queries that cannot be handled by the current SQL engine.

Copy link

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MaxKsyunz
Copy link
Author

Should we list engine limitations here? https://github.com/Yury-Fridlyand/documentation-website/blob/main/_search-plugins/sql/limitation.md#query-processing-engines

Doesn't that page already lists them? Not sure what you'd like to add there.

Signed-off-by: MaxKsyunz <[email protected]>
@MaxKsyunz MaxKsyunz merged commit 09733a5 into integ-doc-sql-ver-note Jul 28, 2022
@Yury-Fridlyand Yury-Fridlyand deleted the dev-doc-sql-ver-note branch January 12, 2023 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants