Skip to content

[Backport 2.19-dev]Remove redundant push-down-filters derived for bucket-non-null agg (#4843) #4851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yuancu merged 3 commits into from
Nov 25, 2025
Merged

[Backport 2.19-dev]Remove redundant push-down-filters derived for bucket-non-null agg (#4843) #4851

yuancu merged 3 commits into from
Nov 25, 2025

Conversation

@qianheng-aws
Copy link
Collaborator

@qianheng-aws qianheng-aws commented Nov 24, 2025

Backport ede63cb from #4843.

@qianheng-aws
Remove redundant push-down-filters derived for bucket-non-null agg (o…
03d3d30 
…pensearch-project#4843)

* Remove redundant push-down-filters derived for bucket-non-null aggregation

Signed-off-by: Heng Qian <[email protected]>

* Address comment

Signed-off-by: Heng Qian <[email protected]>

* Fix name typo

Signed-off-by: Heng Qian <[email protected]>

---------

Signed-off-by: Heng Qian <[email protected]>

(cherry picked from commit ede63cb)
Signed-off-by: Heng Qian <[email protected]>
@qianheng-aws
Fix compiling
9c3e5ac 
Signed-off-by: Heng Qian <[email protected]>
@qianheng-aws
Copy link
Collaborator Author

qianheng-aws commented Nov 24, 2025 

Tests with failures:
 - org.opensearch.sql.ppl.dashboard.NfwPplDashboardIT.testTopTCPFlags
 - org.opensearch.sql.ppl.dashboard.VpcFlowLogsPplDashboardIT.testTopTalkersByIPs
 - org.opensearch.sql.ppl.dashboard.VpcFlowLogsPplDashboardIT.testTopTalkersByPackets
 - org.opensearch.sql.ppl.dashboard.VpcFlowLogsPplDashboardIT.testTopDestinationsByPackets
 - org.opensearch.sql.ppl.dashboard.VpcFlowLogsPplDashboardIT.testTopDestinationsByIPs
 - org.opensearch.sql.ppl.dashboard.WafPplDashboardIT.testTopTerminatingRules

@LantaoJin @yuancu Have you met this failure before? It's weird I cannot reproduce them locally with the given command, e.g.

./gradlew ':integ-test:integTest' --tests 'org.opensearch.sql.ppl.dashboard.NfwPplDashboardIT.testTopTCPFlags' -Dtests.seed=61CD58CB24A1BC70 -Dtests.security.manager=false -Dtests.locale=pt -Dtests.timezone=Asia/Saigon -Druntime.java=11

@qianheng-aws
Fix IT
0851631 
Signed-off-by: Heng Qian <[email protected]>
@qianheng-aws
Copy link
Collaborator Author

qianheng-aws commented Nov 25, 2025 

Tests with failures:
 - org.opensearch.sql.ppl.dashboard.NfwPplDashboardIT.testTopTCPFlags
 - org.opensearch.sql.ppl.dashboard.VpcFlowLogsPplDashboardIT.testTopTalkersByIPs
 - org.opensearch.sql.ppl.dashboard.VpcFlowLogsPplDashboardIT.testTopTalkersByPackets
 - org.opensearch.sql.ppl.dashboard.VpcFlowLogsPplDashboardIT.testTopDestinationsByPackets
 - org.opensearch.sql.ppl.dashboard.VpcFlowLogsPplDashboardIT.testTopDestinationsByIPs
 - org.opensearch.sql.ppl.dashboard.WafPplDashboardIT.testTopTerminatingRules

@LantaoJin @yuancu Have you met this failure before? It's weird I cannot reproduce them locally with the given command, e.g.

./gradlew ':integ-test:integTest' --tests 'org.opensearch.sql.ppl.dashboard.NfwPplDashboardIT.testTopTCPFlags' -Dtests.seed=61CD58CB24A1BC70 -Dtests.security.manager=false -Dtests.locale=pt -Dtests.timezone=Asia/Saigon -Druntime.java=11

Implicitly adding sort order on all fields to ensure sequence of the final results.

@yuancu yuancu merged commit 93b5a74 into opensearch-project:2.19-dev Nov 25, 2025
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LantaoJin LantaoJin LantaoJin approved these changes

@yuancu yuancu yuancu approved these changes

@ps48 ps48 Awaiting requested review from ps48 ps48 is a code owner

@kavithacm kavithacm Awaiting requested review from kavithacm kavithacm is a code owner

@derek-ho derek-ho Awaiting requested review from derek-ho derek-ho is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@dai-chen dai-chen Awaiting requested review from dai-chen dai-chen is a code owner

@YANG-DB YANG-DB Awaiting requested review from YANG-DB YANG-DB is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@Swiddis Swiddis Awaiting requested review from Swiddis Swiddis is a code owner

@penghuo penghuo Awaiting requested review from penghuo penghuo is a code owner

@seankao-az seankao-az Awaiting requested review from seankao-az seankao-az is a code owner

@MaxKsyunz MaxKsyunz Awaiting requested review from MaxKsyunz MaxKsyunz is a code owner

@Yury-Fridlyand Yury-Fridlyand Awaiting requested review from Yury-Fridlyand Yury-Fridlyand is a code owner

@anirudha anirudha Awaiting requested review from anirudha anirudha is a code owner

@forestmvey forestmvey Awaiting requested review from forestmvey forestmvey is a code owner

@acarbonetto acarbonetto Awaiting requested review from acarbonetto acarbonetto is a code owner

@GumpacG GumpacG Awaiting requested review from GumpacG GumpacG is a code owner

@ykmr1224 ykmr1224 Awaiting requested review from ykmr1224 ykmr1224 is a code owner

@noCharger noCharger Awaiting requested review from noCharger noCharger is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@qianheng-aws @LantaoJin @yuancu