Add bucket_nullable argument for Streamstats command
#4831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xinyu Hao <[email protected]>
get the latest codes
Signed-off-by: Xinyu Hao <[email protected]>
Signed-off-by: Xinyu Hao <[email protected]>
ishaoxy
requested review from
GumpacG,
LantaoJin,
MaxKsyunz,
RyanL1997,
Swiddis,
YANG-DB,
Yury-Fridlyand,
acarbonetto,
anirudha,
dai-chen,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
noCharger,
penghuo,
ps48,
qianheng-aws,
seankao-az,
vamsimanohar,
ykmr1224 and
yuancu
as code owners
LantaoJin
reviewed
Nov 21, 2025
| // wrap each expr: CASE WHEN groupNotNull THEN rawExpr ELSE CAST(NULL AS rawType) END | ||
| List<RexNode> wrappedOverExprs = | ||
| wrapWindowFunctionsWithGroupNotNull(overExpressions, groupNotNull, context); | ||
| context.relBuilder.projectPlus(wrappedOverExprs); |
Member
There was a problem hiding this comment.
I think we need a similar work with following code to add a hint to the Project (A better way is adding hint on LogicalWindow but seems we cannot do it now). So does eventstats. This hint is useful during plan optimizing.
yuancu
previously approved these changes
Nov 24, 2025
ppl/src/main/java/org/opensearch/sql/ppl/parser/AstBuilder.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Xinyu Hao <[email protected]>
Signed-off-by: Xinyu Hao <[email protected]>
Signed-off-by: Xinyu Hao <[email protected]>
Signed-off-by: Xinyu Hao <[email protected]>
yuancu
approved these changes
Nov 26, 2025
LantaoJin
approved these changes
Nov 26, 2025
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.19-dev 2.19-dev
# Navigate to the new working tree
pushd ../.worktrees/sql/backport-2.19-dev
# Create a new branch
git switch --create backport/backport-4831-to-2.19-dev
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f7b860b62bea308c00dc995c21f81005690443c4
# Push it to GitHub
git push --set-upstream origin backport/backport-4831-to-2.19-dev
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.19-devThen, create a pull request where the |
Member
|
@ishaoxy please backport^ |
ishaoxy
added a commit
to ishaoxy/sql
that referenced
this pull request
Nov 27, 2025
Signed-off-by: Xinyu Hao <[email protected]>
ishaoxy
added a commit
to ishaoxy/sql
that referenced
this pull request
Nov 27, 2025
Signed-off-by: Xinyu Hao <[email protected]>
8 tasks
ishaoxy
added a commit
to ishaoxy/sql
that referenced
this pull request
Nov 27, 2025
Signed-off-by: Xinyu Hao <[email protected]>
ishaoxy
added a commit
to ishaoxy/sql
that referenced
this pull request
Nov 27, 2025
Signed-off-by: Xinyu Hao <[email protected]>
LantaoJin
pushed a commit
that referenced
this pull request
Nov 28, 2025
…command (#4879) * backport #4831 Signed-off-by: Xinyu Hao <[email protected]> * backport #4831 Signed-off-by: Xinyu Hao <[email protected]> * backport #4831 Signed-off-by: Xinyu Hao <[email protected]> * code format Signed-off-by: Xinyu Hao <[email protected]> * fields lack Signed-off-by: Xinyu Hao <[email protected]> --------- Signed-off-by: Xinyu Hao <[email protected]>
asifabashar
pushed a commit
to asifabashar/sql
that referenced
this pull request
Dec 10, 2025
…project#4831) * add bucket_nullable for streamstats Signed-off-by: Xinyu Hao <[email protected]> * little change Signed-off-by: Xinyu Hao <[email protected]> * fix IT, UT and doc Signed-off-by: Xinyu Hao <[email protected]> * fix Signed-off-by: Xinyu Hao <[email protected]> * change bucketNullable getOrDefault to get Signed-off-by: Xinyu Hao <[email protected]> * fix error Signed-off-by: Xinyu Hao <[email protected]> --------- Signed-off-by: Xinyu Hao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Similar with
statsandeventstats, now we addbucket_nullableargument forstreamstats.ref: #4817
Related Issues
Resolves #4802
Check List
--signoffor-s.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.