Skip to content

Conversation

@ishaoxy
Copy link
Contributor

@ishaoxy ishaoxy commented Nov 18, 2025

Description

Similar with Stats, now we add bucket_nullable argument for Eventstats, to control whether it consider null buckets as a valid group in group-by aggregations.

Related Issues

Resolves #4801

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • New functionality has javadoc added.
  • New functionality has a user manual doc added.
  • New PPL command checklist all confirmed.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff or -s.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

LantaoJin
LantaoJin previously approved these changes Nov 19, 2025
@LantaoJin
Copy link
Member

@ishaoxy please resolve the conflicts

Signed-off-by: Xinyu Hao <[email protected]>
@ishaoxy
Copy link
Contributor Author

ishaoxy commented Nov 19, 2025

Conflicts are resolved. @LantaoJin

@RyanL1997 RyanL1997 merged commit 1ecf42d into opensearch-project:main Nov 19, 2025
67 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.19-dev failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.19-dev 2.19-dev
# Navigate to the new working tree
pushd ../.worktrees/sql/backport-2.19-dev
# Create a new branch
git switch --create backport/backport-4817-to-2.19-dev
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1ecf42d5028bc3bdefffff5ecec8cbd81a471aa4
# Push it to GitHub
git push --set-upstream origin backport/backport-4817-to-2.19-dev
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.19-dev

Then, create a pull request where the base branch is 2.19-dev and the compare/head branch is backport/backport-4817-to-2.19-dev.

@LantaoJin
Copy link
Member

@ishaoxy need to backport manually

yuancu pushed a commit that referenced this pull request Nov 25, 2025
@LantaoJin LantaoJin added the backport-manually Filed a PR to backport manually. label Nov 25, 2025
asifabashar pushed a commit to asifabashar/sql that referenced this pull request Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 2.19-dev backport-failed backport-manually Filed a PR to backport manually. enhancement New feature or request PPL Piped processing language

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC] Add [bucket_nullable=bool] argument for Eventstats command?

3 participants