generated from amazon-archives/__template_Custom
-
Notifications
You must be signed in to change notification settings - Fork 180
Add bucket_nullable argument for Eventstats
#4817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
RyanL1997
merged 2 commits into
opensearch-project:main
from
ishaoxy:eventstats-nullable
Nov 19, 2025
Merged
Add bucket_nullable argument for Eventstats
#4817
RyanL1997
merged 2 commits into
opensearch-project:main
from
ishaoxy:eventstats-nullable
Nov 19, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xinyu Hao <[email protected]>
LantaoJin
previously approved these changes
Nov 19, 2025
Member
|
@ishaoxy please resolve the conflicts |
Signed-off-by: Xinyu Hao <[email protected]>
Contributor
Author
|
Conflicts are resolved. @LantaoJin |
LantaoJin
approved these changes
Nov 19, 2025
RyanL1997
approved these changes
Nov 19, 2025
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.19-dev 2.19-dev
# Navigate to the new working tree
pushd ../.worktrees/sql/backport-2.19-dev
# Create a new branch
git switch --create backport/backport-4817-to-2.19-dev
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1ecf42d5028bc3bdefffff5ecec8cbd81a471aa4
# Push it to GitHub
git push --set-upstream origin backport/backport-4817-to-2.19-dev
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.19-devThen, create a pull request where the |
Member
|
@ishaoxy need to backport manually |
8 tasks
yuancu
pushed a commit
that referenced
this pull request
Nov 25, 2025
) (#4858) Signed-off-by: Xinyu Hao <[email protected]>
asifabashar
pushed a commit
to asifabashar/sql
that referenced
this pull request
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport 2.19-dev
backport-failed
backport-manually
Filed a PR to backport manually.
enhancement
New feature or request
PPL
Piped processing language
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Similar with
Stats, now we addbucket_nullableargument forEventstats, to control whether it consider null buckets as a valid group in group-by aggregations.Related Issues
Resolves #4801
Check List
--signoffor-s.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.