[2.19-dev] Fix/restore stringutils escape handling #4620
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restore string literal escape processing (\, \', ") in StringUtils.unquoteText() that was accidentally removed from the 2.19-dev branch during Spotless formatting backport (commit c6b37d0). This escape handling exists in main branch (added in Feb 2023, commit d608412) but was lost when Spotless changes were backported to 2.x in Aug 2023. Changes: - Restore escape sequence handling in StringUtils.unquoteText() - Update doctest expectations in expressions.rst - Update PPL string function test expectations - Update backslash escaping in SearchCommandIT and WildcardQueryIT tests Without this fix, string literals with escape sequences like 'example\\.com' for regex patterns are not processed correctly. Signed-off-by: Kai Huang <[email protected]>
ahkcs
force-pushed
the
fix/restore-stringutils-escape-handling
branch
from
14f8a4a to
10fcf12
Compare
ahkcs
requested review from
GumpacG,
LantaoJin,
MaxKsyunz,
Swiddis,
YANG-DB,
Yury-Fridlyand,
acarbonetto,
anirudha,
dai-chen,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
noCharger,
penghuo,
ps48,
qianheng-aws,
seankao-az and
ykmr1224
as code owners
Contributor
Author
|
closing as #4604 merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore string literal escape processing (, ', ") in StringUtils.unquoteText() that was accidentally from the 2.19-dev branch during Spotless formatting backport (commit c6b37d0).
This escape handling exists in main branch (added in Feb 2023, commit d608412) but was lost when Spotless changes were backported to 2.x in Aug 2023.
Changes:
Without this fix, string literals with escape sequences like 'example\.com' for regex patterns are not processed correctly.