Skip to content

[Backport 2.19-dev] Add replace command with Calcite (#4451) #4604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
penghuo merged 6 commits into from
Oct 22, 2025
Merged

[Backport 2.19-dev] Add replace command with Calcite (#4451) #4604

penghuo merged 6 commits into from
Oct 22, 2025

Conversation

@ahkcs
Copy link
Contributor

@ahkcs ahkcs commented Oct 20, 2025 •
edited
Loading

  • Add replace command with Calcite

Also fixed discrepancy of escape handling between main and 2.19-dev

Changes

  1. AstBuilder.java: Fixed compilation error (.toList() → .collect(Collectors.toList()))
  2. StringUtils.java: Restored escape handling (\, \', \") that was removed in 2.x Spotless backport (c6b37d0)
  3. expressions.rst: Updated test expectations to match escape handling behavior

(cherry picked from commit 5677765)

ahkcs and others added 6 commits October 20, 2025 10:24
@ahkcs @manasvinibs
Add replace command with Calcite (opensearch-project#4451)
78414e6 
* Add replace command with Calcite

Signed-off-by: Kai Huang <[email protected]>

---------

Signed-off-by: Kai Huang <[email protected]>
Co-authored-by: Manasvini B S <[email protected]>
(cherry picked from commit 5677765)
Signed-off-by: Kai Huang <[email protected]>
@ahkcs
fix compile
a77cb21 
Signed-off-by: Kai Huang <[email protected]>
@ahkcs
backporting backslash handling from main and fix tests
007159f 
Signed-off-by: Kai Huang <[email protected]>
@ahkcs
Fix tests
706fe4f 
Signed-off-by: Kai Huang <[email protected]>
@ahkcs
fix tests
c64d740 
Signed-off-by: Kai Huang <[email protected]>
@ahkcs
compatability accross java versions
dddec6f 
Signed-off-by: Kai Huang <[email protected]>
@ahkcs ahkcs marked this pull request as ready for review October 21, 2025 04:26
@penghuo penghuo enabled auto-merge (squash) October 22, 2025 18:03
@penghuo penghuo merged commit 2fa3845 into opensearch-project:2.19-dev Oct 22, 2025
42 checks passed
This was referenced Oct 22, 2025
Closed
Merged
@ahkcs ahkcs deleted the backport/backport-4451-to-2.19-dev branch October 22, 2025 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@penghuo penghuo penghuo approved these changes

@RyanL1997 RyanL1997 RyanL1997 approved these changes

@ps48 ps48 Awaiting requested review from ps48 ps48 is a code owner

@kavithacm kavithacm Awaiting requested review from kavithacm kavithacm is a code owner

@derek-ho derek-ho Awaiting requested review from derek-ho derek-ho is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@dai-chen dai-chen Awaiting requested review from dai-chen dai-chen is a code owner

@YANG-DB YANG-DB Awaiting requested review from YANG-DB YANG-DB is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@Swiddis Swiddis Awaiting requested review from Swiddis Swiddis is a code owner

@seankao-az seankao-az Awaiting requested review from seankao-az seankao-az is a code owner

@MaxKsyunz MaxKsyunz Awaiting requested review from MaxKsyunz MaxKsyunz is a code owner

@Yury-Fridlyand Yury-Fridlyand Awaiting requested review from Yury-Fridlyand Yury-Fridlyand is a code owner

@anirudha anirudha Awaiting requested review from anirudha anirudha is a code owner

@forestmvey forestmvey Awaiting requested review from forestmvey forestmvey is a code owner

@acarbonetto acarbonetto Awaiting requested review from acarbonetto acarbonetto is a code owner

@GumpacG GumpacG Awaiting requested review from GumpacG GumpacG is a code owner

@ykmr1224 ykmr1224 Awaiting requested review from ykmr1224 ykmr1224 is a code owner

@LantaoJin LantaoJin Awaiting requested review from LantaoJin LantaoJin is a code owner

@noCharger noCharger Awaiting requested review from noCharger noCharger is a code owner

@qianheng-aws qianheng-aws Awaiting requested review from qianheng-aws qianheng-aws is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ahkcs @penghuo @RyanL1997