Skip to content

Conversation

@noCharger
Copy link
Collaborator

@noCharger noCharger commented Sep 2, 2025

Description

Align source ppl query to big5 dsl used for benchmark. Verified query results are the same between PPL and DSL on modified queries in this PR, besides issues identified:

DSL https://github.com/opensearch-project/opensearch-benchmark-workloads/blob/main/big5/operations/default.json

Related Issues

opensearch-project/opensearch-benchmark-workloads#691

Check List

  • New functionality includes testing.
    - [ ] New functionality has been documented.
    - [ ] New functionality has javadoc added.
    - [ ] New functionality has a user manual doc added.
    - [ ] New PPL command checklist all confirmed.
    - [ ] API changes companion pull request created.
  • Commits are signed per the DCO using --signoff or -s.
    - [ ] Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

source = big5
| where `@timestamp` >= '2022-12-30 00:00:00' and `@timestamp` < '2023-01-01 03:00:00'
| stats count() by `process.name`, `event.id`, `cloud.region`
| where `@timestamp` >= '2023-01-05 00:00:00' and `@timestamp` < '2023-01-05 05:00:00'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{
  "size": 0,
  "query": {
    "range": {
      "@timestamp": {
        "gte": "2022-12-30T00:00:00",
        "lt": "2023-01-01T03:00:00"
      }
    }
  },
  "aggs": {
    "important_terms": {
      "multi_terms": {
        "terms": [
          {
            "field": "process.name"
          },
          {
            "field": "event.id"
          },
          {
            "field": "cloud.region"
          }
        ]
      }
    }
  }
}

This correspond DSL query to PPL. Why change timerange?

| where `process.name` = 'systemd'
and `metrics.size` >= 1
and `metrics.size` <= 1000
| where `process.name` = 'systemd' and `metrics.size` >= 1 and `metrics.size` <= 100
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there are difference sources of Big5 DSL. The original PPL was translated from the DSL listed above. But @noCharger seems find another source of Big5 DSL.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@noCharger noCharger requested a review from penghuo September 3, 2025 16:41
LantaoJin
LantaoJin previously approved these changes Sep 3, 2025
@LantaoJin
Copy link
Member

LantaoJin commented Sep 3, 2025

@noCharger can you call out the true source of DSL in the description? Seems there are some different in benchmark repo. So we should call out the source we aligned.

@noCharger
Copy link
Collaborator Author

@noCharger can you call out the true source of DSL in the description? Seems there are some different in benchmark repo. So we should call out the source we aligned.

Yes it's already in description.

@opensearch-trigger-bot
Copy link
Contributor

This PR is stalled because it has been open for 30 days with no activity.

@penghuo
Copy link
Collaborator

penghuo commented Oct 8, 2025

@noCharger resolve conflict

@noCharger
Copy link
Collaborator Author

@noCharger resolve conflict

@penghuo 7ee09ce

@opensearch-trigger-bot
Copy link
Contributor

This PR is stalled because it has been open for 2 weeks with no activity.

@RyanL1997
Copy link
Collaborator

closiing due to #4668

@RyanL1997 RyanL1997 closed this Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request stalled

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants