Skip to content

Conversation

@noCharger
Copy link
Contributor

@noCharger noCharger commented Sep 2, 2025

Description

Align source ppl query to big5 dsl used for benchmark

DSL https://github.com/opensearch-project/opensearch-benchmark-workloads/blob/main/big5/operations/default.json
PPL https://github.com/opensearch-project/opensearch-benchmark-workloads/blob/main/big5/operations/ppl.json

Testing

  • New functionality includes testing

[Describe how this change was tested]

Backport to Branches:

  • 6
  • 7
  • 1
  • 2
  • 3

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@noCharger noCharger force-pushed the fix-big5-ppl-queries branch from 4117810 to 252a6c8 Compare September 2, 2025 20:25
@noCharger noCharger marked this pull request as ready for review September 2, 2025 20:25
@noCharger noCharger changed the title Align source ppl query to dsl Align big5 ppl queries to dsl Sep 2, 2025
@noCharger noCharger force-pushed the fix-big5-ppl-queries branch from 252a6c8 to 7cf368d Compare September 3, 2025 04:09
@LantaoJin
Copy link
Member

LantaoJin commented Sep 3, 2025

Does any repo maintainer know why the DSLs in default.json and https://github.com/opensearch-project/opensearch-benchmark-workloads/tree/main/big5/queries folder are different?
For example:
"lt": "2023-01-01T03:00:00" in https://github.com/opensearch-project/opensearch-benchmark-workloads/blob/2fbd2c7a96a3844bf41c12799e28bc539739d609/big5/queries/multi_terms-keyword.json#L7C9-L7C36,
but "lt": "2023-01-05T05:00:00" in https://github.com/opensearch-project/opensearch-benchmark-workloads/blob/2fbd2c7a96a3844bf41c12799e28bc539739d609/big5/operations/default.json#L736C15-L736C42

@rishabh6788
Copy link
Collaborator

I don't know the historical reason for adding queries folder, the actual operation is picked from operations/default.json file.
Do the changes made to PPL operations provide apples-to-apples comparison to DSL?

@rishabh6788 rishabh6788 merged commit a485c24 into opensearch-project:main Sep 3, 2025
3 checks passed
@IanHoang IanHoang added the v3.3.0 label Oct 2, 2025
@noCharger noCharger self-assigned this Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: New

Development

Successfully merging this pull request may close these issues.

4 participants