[Backport 2.x] Delete Spark datasource (#2638) #2667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Delete Spark datasource Signed-off-by: Tomoyuki Morita <[email protected]> * Fix build error Signed-off-by: Tomoyuki Morita <[email protected]> * Delete spark_connector.rst Signed-off-by: Tomoyuki Morita <[email protected]> * Add missing test Signed-off-by: Tomoyuki Morita <[email protected]> --------- Signed-off-by: Tomoyuki Morita <[email protected]> (cherry picked from commit de7b367) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Tomoyuki Morita <[email protected]>
ykmr1224
changed the title
Signed-off-by: Tomoyuki Morita <[email protected]>
ykmr1224
requested review from
GumpacG,
MaxKsyunz,
Swiddis,
YANG-DB,
Yury-Fridlyand,
acarbonetto,
anirudha,
dai-chen,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
penghuo,
ps48,
rupal-bq,
seankao-az and
vamsimanohar
as code owners
seankao-az
reviewed
May 13, 2024
| assertEquals(new ExprDoubleValue(6.1), row.get("col6")); | ||
| assertEquals(new ExprFloatValue(7.1), row.get("col7")); | ||
| assertEquals(new ExprTimestampValue("2024-01-02 03:04:05.1234"), row.get("col8")); | ||
| assertEquals(new ExprStringValue("2024-01-02 03:04:05.1234"), row.get("col8")); |
Collaborator
There was a problem hiding this comment.
curious if we actually want ExprDatetimeValue here instead? my understanding is without #1980 we're using ExprDatetimeValue not ExprStringValue
Collaborator
Author
There was a problem hiding this comment.
The actual representation of the value is String. (sparkType:"timestamp" is considered as ExprCoreType.DATE, and ExprCoreType.DATE item is converted to ExprStringValue.) I'm planning to remove this data conversion and directly return spark data types as response.
Swiddis
approved these changes
May 13, 2024
seankao-az
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.