Skip to content

Conversation

@matthewryanwells
Copy link
Contributor

Description

Removes the DATETIME data type as it is made redundant by the presence of TIMESTAMP.

Updated all functions that returned DATETIME to now return TIMESTAMP and removed it from all other functions, tests, and documentation.

Issues Resolved

#1176

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.30%. Comparing base (ac9b5d8) to head (9764fe2).
Report is 358 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1980      +/-   ##
============================================
- Coverage     97.33%   97.30%   -0.04%     
+ Complexity     4657     4621      -36     
============================================
  Files           408      407       -1     
  Lines         12097    11932     -165     
  Branches        829      826       -3     
============================================
- Hits          11775    11610     -165     
  Misses          315      315              
  Partials          7        7              
Flag Coverage Δ
sql-engine 97.30% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to rerun spotless on files you modified and commit the changes from spotless

acarbonetto
acarbonetto previously approved these changes Aug 17, 2023
Yury-Fridlyand
Yury-Fridlyand previously approved these changes Aug 18, 2023
* removed datetime type, updated tests and documentation

Signed-off-by: Matthew Wells <[email protected]>
@MitchellGale
Copy link
Contributor

There are some conflicts to resolve @matthewryanwells

@matthewryanwells matthewryanwells force-pushed the integ-reduce-ExprCoreTypes branch from cc12e92 to 5597643 Compare August 21, 2023 16:11
@matthewryanwells
Copy link
Contributor Author

There are some conflicts to resolve @matthewryanwells

Just resolved the merge conflicts

@Yury-Fridlyand Yury-Fridlyand merged commit 25beda0 into opensearch-project:main Aug 21, 2023
@Yury-Fridlyand Yury-Fridlyand deleted the integ-reduce-ExprCoreTypes branch August 21, 2023 16:57
@Yury-Fridlyand Yury-Fridlyand restored the integ-reduce-ExprCoreTypes branch August 21, 2023 16:57
@Yury-Fridlyand Yury-Fridlyand deleted the integ-reduce-ExprCoreTypes branch August 21, 2023 16:57
@LantaoJin
Copy link
Member

@penghuo @dai-chen I found this change is not presented in 2.x branch, so it should be a breaking change for 3.0.0.

@penghuo penghuo added the v3.0.0 label Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants