-
Notifications
You must be signed in to change notification settings - Fork 179
Remove Datetime data type #1980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Datetime data type #1980
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1980 +/- ##
============================================
- Coverage 97.33% 97.30% -0.04%
+ Complexity 4657 4621 -36
============================================
Files 408 407 -1
Lines 12097 11932 -165
Branches 829 826 -3
============================================
- Hits 11775 11610 -165
Misses 315 315
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Yury-Fridlyand
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to rerun spotless on files you modified and commit the changes from spotless
core/src/test/java/org/opensearch/sql/data/model/DateTimeValueTest.java
Outdated
Show resolved
Hide resolved
core/src/test/java/org/opensearch/sql/data/model/ExprValueCompareTest.java
Show resolved
Hide resolved
core/src/test/java/org/opensearch/sql/data/model/ExprValueCompareTest.java
Show resolved
Hide resolved
24d6417 to
36e4a07
Compare
* removed datetime type, updated tests and documentation Signed-off-by: Matthew Wells <[email protected]>
…constant Signed-off-by: Matthew Wells <[email protected]>
…e difference Signed-off-by: Matthew Wells <[email protected]>
|
There are some conflicts to resolve @matthewryanwells |
Signed-off-by: Matthew Wells <[email protected]>
Signed-off-by: Matthew Wells <[email protected]>
Signed-off-by: Matthew Wells <[email protected]>
Signed-off-by: Matthew Wells <[email protected]>
cc12e92 to
5597643
Compare
Signed-off-by: Matthew Wells <[email protected]>
Just resolved the merge conflicts |
Description
Removes the
DATETIMEdata type as it is made redundant by the presence ofTIMESTAMP.Updated all functions that returned
DATETIMEto now returnTIMESTAMPand removed it from all other functions, tests, and documentation.Issues Resolved
#1176
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.