[Backport 2.9] Filter datasource encryption master key from cluster s… #1844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ettings GET API (#1828) * Restrict master key reading from cluster settings API (#1825) Signed-off-by: Vamsi Manohar <[email protected]> (cherry picked from commit a8ecd2f) * Fxied DatasourceClusterSettingsIT for 2.x Signed-off-by: Vamsi Manohar <[email protected]> --------- Signed-off-by: Vamsi Manohar <[email protected]> Co-authored-by: Vamsi Manohar <[email protected]> (cherry picked from commit 98ca9f8)
vamsimanohar
requested review from
GumpacG,
MaxKsyunz,
Swiddis,
YANG-DB,
Yury-Fridlyand,
acarbonetto,
anirudha,
dai-chen,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
penghuo,
pjfitzgibbons,
ps48,
rupal-bq and
seankao-az
as code owners
vamsimanohar
changed the title
Codecov Report
@@ Coverage Diff @@
## 2.9 #1844 +/- ##
=========================================
Coverage 97.35% 97.35%
Complexity 4443 4443
=========================================
Files 388 388
Lines 10998 10998
Branches 784 784
=========================================
Hits 10707 10707
Misses 284 284
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
penghuo
approved these changes
Jul 11, 2023
ps48
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ettings GET API (#1828)
Signed-off-by: Vamsi Manohar [email protected]
(cherry picked from commit a8ecd2f)
Signed-off-by: Vamsi Manohar [email protected]
Signed-off-by: Vamsi Manohar [email protected]
Co-authored-by: Vamsi Manohar [email protected]
(cherry picked from commit 98ca9f8)
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.