generated from amazon-archives/__template_Custom
-
Notifications
You must be signed in to change notification settings - Fork 181
[Backport 2.x] Filter datasource encryption master key from cluster settings GET API #1828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vamsi Manohar <[email protected]> (cherry picked from commit a8ecd2f)
YANG-DB
previously approved these changes
Jul 11, 2023
Codecov Report
@@ Coverage Diff @@
## 2.x #1828 +/- ##
============================================
+ Coverage 97.35% 97.44% +0.08%
- Complexity 4443 4622 +179
============================================
Files 388 388
Lines 10998 11385 +387
Branches 784 837 +53
============================================
+ Hits 10707 11094 +387
Misses 284 284
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Vamsi Manohar <[email protected]>
vamsimanohar
approved these changes
Jul 11, 2023
rupal-bq
approved these changes
Jul 11, 2023
Contributor
Author
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.9 2.9
# Navigate to the new working tree
pushd ../.worktrees/backport-2.9
# Create a new branch
git switch --create backport/backport-1828-to-2.9
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 98ca9f861d81407b1df1840a64f6f4c6f8cd3775
# Push it to GitHub
git push --set-upstream origin backport/backport-1828-to-2.9
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.9Then, create a pull request where the |
vamsimanohar
added a commit
that referenced
this pull request
Jul 11, 2023
…ettings GET API (#1828) * Restrict master key reading from cluster settings API (#1825) Signed-off-by: Vamsi Manohar <[email protected]> (cherry picked from commit a8ecd2f) * Fxied DatasourceClusterSettingsIT for 2.x Signed-off-by: Vamsi Manohar <[email protected]> --------- Signed-off-by: Vamsi Manohar <[email protected]> Co-authored-by: Vamsi Manohar <[email protected]> (cherry picked from commit 98ca9f8)
6 tasks
vamsimanohar
added a commit
that referenced
this pull request
Jul 11, 2023
…ettings GET API (#1828) (#1844) * Restrict master key reading from cluster settings API (#1825) Signed-off-by: Vamsi Manohar <[email protected]> (cherry picked from commit a8ecd2f) * Fxied DatasourceClusterSettingsIT for 2.x Signed-off-by: Vamsi Manohar <[email protected]> --------- Signed-off-by: Vamsi Manohar <[email protected]> Co-authored-by: Vamsi Manohar <[email protected]> (cherry picked from commit 98ca9f8) Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport a8ecd2f from #1825