Skip to content

Conversation

@margarit-h
Copy link
Contributor

@margarit-h margarit-h commented Dec 9, 2022

  • Add reverse() string function to V2

Signed-off-by: Margarit Hakobyan [email protected]

Description

Usage: REVERSE(str) returns reversed string of the string supplied as an argument. Returns NULL if the argument is NULL.

Argument type: STRING

Return type: STRING

Example::

os> SELECT REVERSE('abcde')
fetched rows / total rows = 1/1
+--------------------+
| REVERSE('abcde')   |
|--------------------|
| edcba              |
+--------------------+

Example::

os> source=people | eval `REVERSE('abcde')` = REVERSE('abcde') | fields `REVERSE('abcde')`
fetched rows / total rows = 1/1
+--------------------+
| REVERSE('abcde')   |
|--------------------|
| edcba              |
+--------------------+

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

* Add reverse() string function to V2

Signed-off-by: Margarit Hakobyan <[email protected]>
@margarit-h margarit-h requested a review from a team as a code owner December 9, 2022 17:31
Copy link
Collaborator

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

@dai-chen dai-chen added the enhancement New feature or request label Dec 9, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.81%. Comparing base (2af7321) to head (2da8408).
⚠️ Report is 456 commits behind head on 2.x.

❌ Your project status has failed because the head coverage (95.81%) is below the target coverage (99.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##                2.x    #1154      +/-   ##
============================================
- Coverage     98.30%   95.81%   -2.50%     
- Complexity     3518     3521       +3     
============================================
  Files           342      352      +10     
  Lines          8694     9358     +664     
  Branches        554      673     +119     
============================================
+ Hits           8547     8966     +419     
- Misses          142      334     +192     
- Partials          5       58      +53     
Flag Coverage Δ
query-workbench 62.76% <ø> (?)
sql-engine 98.31% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MaxKsyunz MaxKsyunz merged commit c923e80 into opensearch-project:2.x Dec 9, 2022
@MaxKsyunz MaxKsyunz deleted the integ-add-reverse-to-v2 branch December 9, 2022 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants