Add reverse() string function to V2 #183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## integ-add-reverse-to-v2 #183 +/- ##
==========================================================
Coverage 98.30% 98.31%
- Complexity 3518 3521 +3
==========================================================
Files 342 342
Lines 8694 8700 +6
Branches 554 554
==========================================================
+ Hits 8547 8553 +6
Misses 142 142
Partials 5 5
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
margarit-h
changed the title
acarbonetto
requested changes
Dec 6, 2022
core/src/main/java/org/opensearch/sql/expression/function/BuiltinFunctionName.java
Outdated
Show resolved
Hide resolved
docs/user/ppl/functions/string.rst
Outdated
| Description | ||
| >>>>>>>>>>> | ||
|
|
||
| Usage: REVERSE(str) returns reversed string of the string supplied as an argument. Returns NULL if the argument is NULL. |
There was a problem hiding this comment.
Since we're mentioning it here, we should add the NULL case to the test below
| @Test | ||
| public void testReverse() throws IOException { | ||
| verifyQuery("reverse('hello')", "keyword", "olleh"); | ||
| verifyQuery("reverse('')", "keyword", ""); |
Yury-Fridlyand
approved these changes
Dec 7, 2022
Yury-Fridlyand
requested review from
GumpacG,
MaxKsyunz,
MitchellGale and
forestmvey
acarbonetto
approved these changes
Dec 7, 2022
GumpacG
approved these changes
Dec 8, 2022
Signed-off-by: Margarit Hakobyan <[email protected]>
Signed-off-by: Margarit Hakobyan <[email protected]>
Signed-off-by: Margarit Hakobyan <[email protected]>
Signed-off-by: Margarit Hakobyan <[email protected]>
margarit-h
force-pushed
the
dev-add-reverse-to-v2
branch
from
4430764 to
555e1a0
Compare
Signed-off-by: Margarit Hakobyan <[email protected]>
MitchellGale
approved these changes
Dec 8, 2022
Signed-off-by: Margarit Hakobyan <[email protected]>
GabeFernandez310
approved these changes
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Margarit Hakobyan [email protected]
Description
Usage: REVERSE(str) returns reversed string of the string supplied as an argument. Returns NULL if the argument is NULL.
Argument type: STRING
Return type: STRING
Example::
Example::
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.