Skip to content

[Backport 2.x] Misc changes#2904

Merged
peternied merged 1 commit into2.xfrom
backport/backport-2902-to-2.x
Jun 28, 2023
Merged

[Backport 2.x] Misc changes#2904
peternied merged 1 commit into2.xfrom
backport/backport-2902-to-2.x

Conversation

@opensearch-trigger-bot
Copy link
Contributor

Backport 71266de from #2902

@willyborankin
Copy link
Collaborator

willyborankin commented Jun 26, 2023

Hmmm it fails with clusterService.state().getMetadata().getIndices().valuesIt(); refactoring in OpenSearch?

@cwperks
Copy link
Member

cwperks commented Jun 26, 2023

Hmmm it fails with clusterService.state().getMetadata().getIndices().valuesIt(); refactoring in OpenSearch?

Yes. the backport was recently merged 1 hour ago in core: opensearch-project/OpenSearch#8241

@cwperks
Copy link
Member

cwperks commented Jun 27, 2023

@willyborankin The CI is still running, but this backport PR for 2.x should fix the build issues on that branch: #2908

Moved isStatic and isReserved methods to the
SecurityDynamicConfiguration class

Signed-off-by: Andrey Pleskach <ples@aiven.io>
(cherry picked from commit 71266de)
@willyborankin willyborankin force-pushed the backport/backport-2902-to-2.x branch from 6f19301 to d0cc9b9 Compare June 27, 2023 19:05
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #2904 (d0cc9b9) into 2.x (94f0ec1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##                2.x    #2904   +/-   ##
=========================================
  Coverage     62.13%   62.13%           
  Complexity     3374     3374           
=========================================
  Files           264      264           
  Lines         19443    19441    -2     
  Branches       3315     3315           
=========================================
- Hits          12081    12080    -1     
+ Misses         5767     5766    -1     
  Partials       1595     1595           
Impacted Files Coverage Δ
...arch/security/dlic/rest/api/AbstractApiAction.java 75.95% <100.00%> (-0.46%) ⬇️
...ecurityconf/impl/SecurityDynamicConfiguration.java 74.25% <100.00%> (+1.80%) ⬆️

... and 2 files with indirect coverage changes

@peternied peternied merged commit b81522b into 2.x Jun 28, 2023
@peternied peternied deleted the backport/backport-2902-to-2.x branch June 28, 2023 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants