[Backport 2.x] [Refactor] Metadata members from ImmutableOpenMap to j.u.Map (#7165)#8241
Merged
nknize merged 3 commits intoopensearch-project:2.xfrom Jun 26, 2023
Merged
Conversation
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
Gradle Check (Jenkins) Run Completed with:
|
…pensearch-project#7126) With java.util.Map immutability and collection improvements the hppc ImmutableOpenMap is not needed in ClusterInfo. This commit refactors ClusterInfo to use java Maps and Immutable Collections and further trim the dependency on the aging hppc library. Signed-off-by: Nicholas Walter Knize <[email protected]>
…rch-project#7165) Refactors Metadata.{indices, templates, customs} member variables from ImmutableOpenMap to use jdk Maps. Usage of these variables across the codebase is also refactored to use jdk maps. Signed-off-by: Nicholas Walter Knize <[email protected]>
Signed-off-by: Nicholas Walter Knize <[email protected]>
89bc467 to
ba756e7
Compare
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## 2.x #8241 +/- ##
============================================
- Coverage 70.72% 70.61% -0.12%
+ Complexity 56865 56842 -23
============================================
Files 4703 4705 +2
Lines 269109 269154 +45
Branches 39778 39785 +7
============================================
- Hits 190333 190068 -265
- Misses 62468 62774 +306
- Partials 16308 16312 +4
|
andrross
approved these changes
Jun 26, 2023
gaiksaya
pushed a commit
to gaiksaya/OpenSearch
that referenced
this pull request
Jun 26, 2023
…ableOpenMap to j.u.Map (opensearch-project#7126) (opensearch-project#7165) (opensearch-project#8241) * [Refactor] ClusterInfo to use j.util.Map instead of ImmutableOpenMap (opensearch-project#7126) With java.util.Map immutability and collection improvements the hppc ImmutableOpenMap is not needed in ClusterInfo. This commit refactors ClusterInfo to use java Maps and Immutable Collections and further trim the dependency on the aging hppc library. * [Refactor] Metadata members from ImmutableOpenMap to j.u.Map (opensearch-project#7165) Refactors Metadata.{indices, templates, customs} member variables from ImmutableOpenMap to use jdk Maps. Usage of these variables across the codebase is also refactored to use jdk maps. --------- Signed-off-by: Nicholas Walter Knize <[email protected]>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport 1ab22e1 from #7165.