Windows Install Action Fix

[stephen-crawford]

Description

This fix resolves the issue with the Windows install. The -y flag in the demo scripts was not actually setting the config settings correctly.

Issues Resolved

Resolves issue #2305

Testing

I ran the full workflow suite and everything worked.

Check List

• New functionality includes testing
• New functionality has been documented
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[DarshitChanpura]

for my knowledge, what would this do?

[cwperks]

It sets all of the individual flags to true, assumeyes mean yes to all of initsecurity, clustermode and skip_updated (which is already defaulted to true).

Good catch @scrawfor99 !

[DarshitChanpura]

will this need to be dynamically changed to "no" at any time in future?

[cwperks]

No is the default, if -y is not specified then you get prompted for input to choose.

-y advertises that it accepts all prompts, but its not working as advertised without this fix.

[DarshitChanpura]

ah..gotcha.. thank you @cwperks!

[peternied]

Nice catch!

[codecov-commenter]

Codecov Report

Merging #2308 (622e2ea) into main (c8095bc) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #2308      +/-   ##
============================================
- Coverage     61.04%   61.01%   -0.03%     
+ Complexity     3268     3266       -2     
============================================
  Files           259      259              
  Lines         18337    18337              
  Branches       3248     3248              
============================================
- Hits          11193    11189       -4     
- Misses         5559     5562       +3     
- Partials       1585     1586       +1     

Impacted Files	Coverage Δ
...ch/security/auditlog/routing/AsyncStoragePool.java	50.00% <0.00%> (-5.56%)	⬇️
.../dlic/auth/ldap2/LDAPConnectionFactoryFactory.java	57.46% <0.00%> (-1.50%)	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[stephen-crawford]

For some reason JDK 11 Linux build fails and says there is an issue with the findOpenStream. Was this an issue we are aware of? I do not know why only 11 would have an issue but do not want to fix Windows at the expense of Linux obviously. I can look more tomorrow if this seems like an introduced issue from this PR.

[cwperks]

I think its flaky. I see TimeoutException[Timeout after 10SECONDS while retrieving configuration for [ROLESMAPPING](index=.opendistro_security)]; in the logs.

[opensearch-trigger-bot]

The backport to 1.3 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.3 1.3
# Navigate to the new working tree
cd .worktrees/backport-1.3
# Create a new branch
git switch --create backport/backport-2308-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 aad93794227fca92703ceda24459038703c2a8cc
# Push it to GitHub
git push --set-upstream origin backport/backport-2308-to-1.3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.3

Then, create a pull request where the base branch is 1.3 and the compare/head branch is backport/backport-2308-to-1.3.

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2308-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 aad93794227fca92703ceda24459038703c2a8cc
# Push it to GitHub
git push --set-upstream origin backport/backport-2308-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-2308-to-2.x.

[opensearch-trigger-bot]

The backport to 2.4 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.4 2.4
# Navigate to the new working tree
cd .worktrees/backport-2.4
# Create a new branch
git switch --create backport/backport-2308-to-2.4
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 aad93794227fca92703ceda24459038703c2a8cc
# Push it to GitHub
git push --set-upstream origin backport/backport-2308-to-2.4
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.4

Then, create a pull request where the base branch is 2.4 and the compare/head branch is backport/backport-2308-to-2.4.