Skip to content

[Backport 2.4] Adds Plugin Install Workflow and Action #2313

Merged
peternied merged 7 commits intoopensearch-project:2.4from
stephen-crawford:2.4
Dec 13, 2022
Merged

[Backport 2.4] Adds Plugin Install Workflow and Action #2313
peternied merged 7 commits intoopensearch-project:2.4from
stephen-crawford:2.4

Conversation

@stephen-crawford
Copy link
Contributor

@stephen-crawford stephen-crawford commented Dec 8, 2022

Signed-off-by: Stephen Crawford steecraw@amazon.com

Description

Addresses changes that standardize the plugin install workflow across versions and makes older versions compatible with being called from other repos.

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Stephen Crawford <steecraw@amazon.com>
@stephen-crawford stephen-crawford requested a review from a team December 8, 2022 19:55
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
peternied
peternied previously approved these changes Dec 8, 2022
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2022

Codecov Report

Merging #2313 (6bc332d) into 2.4 (07802ac) will increase coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 6bc332d differs from pull request most recent head 8af2ccd. Consider uploading reports for the commit 8af2ccd to get more accurate results

@@             Coverage Diff              @@
##                2.4    #2313      +/-   ##
============================================
+ Coverage     61.05%   61.09%   +0.03%     
- Complexity     3249     3266      +17     
============================================
  Files           258      258              
  Lines         18131    18165      +34     
  Branches       3232     3241       +9     
============================================
+ Hits          11069    11097      +28     
- Misses         5491     5495       +4     
- Partials       1571     1573       +2     
Impacted Files Coverage Δ
.../dlic/auth/ldap2/LDAPConnectionFactoryFactory.java 57.46% <0.00%> (-1.50%) ⬇️
...security/dlic/rest/api/InternalUsersApiAction.java 85.18% <0.00%> (+1.40%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@peternied
Copy link
Member

Shouldn't the remote repo be able to use this action from main no matter the versions of the plugin they are installing?

@stephen-crawford
Copy link
Contributor Author

The artifacts of main are broken right now so to keep working on stuff I needed a building version to have the same logic in it.

@peternied
Copy link
Member

Not sure what happened with the triggering of the CI systems, but checking source fork, everything passed the most recent commit, stephen-crawford@8af2ccd

Merging!

@peternied peternied merged commit 45f0d3e into opensearch-project:2.4 Dec 13, 2022
@stephen-crawford stephen-crawford deleted the 2.4 branch March 30, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants